Skip to content

Update Auth to use PasswordPolicyImpl for validation #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2023
Merged

Update Auth to use PasswordPolicyImpl for validation #7451

merged 3 commits into from
Jul 12, 2023

Conversation

ch5zzy
Copy link
Contributor

@ch5zzy ch5zzy commented Jul 12, 2023

Update AuthImpl to use the internal PasswordPolicyImpl for performing password validation. Also, update test cases to include fields used in the policy internally.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 928a7b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ch5zzy ch5zzy requested a review from Xiaoshouzi-gh July 12, 2023 21:19
@ch5zzy ch5zzy marked this pull request as ready for review July 12, 2023 21:19
@ch5zzy ch5zzy requested review from lisajian, prameshj, renkelvin, sam-gc and a team as code owners July 12, 2023 21:19
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (ca662bd)Merge (df18ec1)Diff
    browser172 kB173 kB+1.27 kB (+0.7%)
    cordova200 kB202 kB+1.43 kB (+0.7%)
    esm5225 kB227 kB+1.43 kB (+0.6%)
    main170 kB171 kB+1.43 kB (+0.8%)
    module172 kB173 kB+1.27 kB (+0.7%)
    react-native185 kB186 kB+1.43 kB (+0.8%)

  • @firebase/auth/cordova

    TypeBase (ca662bd)Merge (df18ec1)Diff
    browser200 kB202 kB+1.43 kB (+0.7%)
    module200 kB202 kB+1.43 kB (+0.7%)

  • @firebase/auth/internal

    TypeBase (ca662bd)Merge (df18ec1)Diff
    browser183 kB184 kB+1.27 kB (+0.7%)
    esm5239 kB240 kB+1.43 kB (+0.6%)
    main206 kB207 kB+1.43 kB (+0.7%)
    module183 kB184 kB+1.27 kB (+0.7%)

  • @firebase/auth/react-native

    TypeBase (ca662bd)Merge (df18ec1)Diff
    browser185 kB186 kB+1.43 kB (+0.8%)
    module185 kB186 kB+1.43 kB (+0.8%)

  • bundle

    TypeBase (ca662bd)Merge (df18ec1)Diff
    auth (Anonymous)72.0 kB73.0 kB+997 B (+1.4%)
    auth (EmailAndPassword)77.0 kB78.0 kB+997 B (+1.3%)
    auth (GoogleFBTwitterGitHubPopup)98.2 kB99.2 kB+997 B (+1.0%)
    auth (GooglePopup)95.5 kB96.5 kB+997 B (+1.0%)
    auth (GoogleRedirect)95.7 kB96.7 kB+997 B (+1.0%)
    auth (Phone)81.9 kB82.9 kB+997 B (+1.2%)

  • firebase

    TypeBase (ca662bd)Merge (df18ec1)Diff
    firebase-auth-compat.js133 kB134 kB+975 B (+0.7%)
    firebase-auth-cordova.js149 kB150 kB+1.08 kB (+0.7%)
    firebase-auth-react-native.js161 kB163 kB+1.08 kB (+0.7%)
    firebase-auth.js128 kB129 kB+977 B (+0.8%)
    firebase-compat.js774 kB775 kB+975 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fHBotQJFaE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (142,070 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/B5KElmrtQN.html

Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Jul 12, 2023
View reviewed changes
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch5zzy ch5zzy merged commit 97f46f5 into password-policy Jul 12, 2023
@ch5zzy ch5zzy deleted the update-auth-to-use-internal-policy branch July 12, 2023 23:27
ch5zzy added a commit that referenced this pull request Jul 13, 2023
@ch5zzy
Update Auth to use PasswordPolicyImpl for validation (#7451)
74515b7 
* Update Auth to use PasswordPolicyImpl for validation

* Rename _getPasswordPolicy to _getPasswordPolicyInternal
@firebase firebase locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

@lisajian lisajian Awaiting requested review from lisajian

@prameshj prameshj Awaiting requested review from prameshj

@renkelvin renkelvin Awaiting requested review from renkelvin

@sam-gc sam-gc Awaiting requested review from sam-gc

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ch5zzy @google-oss-bot @Xiaoshouzi-gh