Include the character option statuses even when an empty string is inputted to validatePassword #7471

ch5zzy · 2023-07-17T20:11:19Z

Fix validatePasswordCharacterOptions to include the character options statuses even when an empty string is inputted.

…putted

changeset-bot · 2023-07-17T20:11:22Z

⚠️ No Changeset found

Latest commit: efcbc06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ch5zzy · 2023-07-17T20:15:20Z

packages/auth/src/core/auth/password_policy_impl.ts

+    // Assign statuses for requirements even if the password is an empty string.
+    this.updatePasswordCharacterOptionsStasuses(
+      status,
+      /* containsLowercaseCharacter= */ false,


I added parameter name comments to make this more readable as per the TS/JS style guide.

google-oss-bot · 2023-07-17T20:33:21Z

Size Report ¹

Affected Products

`@firebase/auth`

Type	Base (`1025840`)	Merge (`9566758`)	Diff
browser	176 kB	176 kB	+399 B (+0.2%)
cordova	204 kB	205 kB	+438 B (+0.2%)
esm5	229 kB	230 kB	+438 B (+0.2%)
main	174 kB	174 kB	+438 B (+0.3%)
module	176 kB	176 kB	+399 B (+0.2%)
react-native	189 kB	190 kB	+438 B (+0.2%)

@firebase/auth/cordova
Type Base (1025840) Merge (9566758) Diff
browser 204 kB 205 kB +438 B (+0.2%)
module 204 kB 205 kB +438 B (+0.2%)
@firebase/auth/internal
Type Base (1025840) Merge (9566758) Diff
browser 186 kB 187 kB +399 B (+0.2%)
esm5 243 kB 243 kB +438 B (+0.2%)
main 210 kB 211 kB +438 B (+0.2%)
module 186 kB 187 kB +399 B (+0.2%)
@firebase/auth/react-native
Type Base (1025840) Merge (9566758) Diff
browser 189 kB 190 kB +438 B (+0.2%)
module 189 kB 190 kB +438 B (+0.2%)

`bundle`

Type	Base (`1025840`)	Merge (`9566758`)	Diff
auth (Anonymous)	74.5 kB	74.7 kB	+176 B (+0.2%)
auth (EmailAndPassword)	79.4 kB	79.6 kB	+176 B (+0.2%)
auth (GoogleFBTwitterGitHubPopup)	101 kB	101 kB	+176 B (+0.2%)
auth (GooglePopup)	98.0 kB	98.1 kB	+176 B (+0.2%)
auth (GoogleRedirect)	98.2 kB	98.4 kB	+176 B (+0.2%)
auth (Phone)	84.3 kB	84.5 kB	+176 B (+0.2%)

`firebase`

Type	Base (`1025840`)	Merge (`9566758`)	Diff
firebase-auth-compat.js	136 kB	136 kB	+164 B (+0.1%)
firebase-auth-cordova.js	152 kB	152 kB	+190 B (+0.1%)
firebase-auth-react-native.js	164 kB	165 kB	+190 B (+0.1%)
firebase-auth.js	130 kB	131 kB	+164 B (+0.1%)
firebase-compat.js	777 kB	777 kB	+164 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/Udve9ctRM0.html

google-oss-bot · 2023-07-17T20:54:02Z

Size Analysis Report ¹

Affected Products

@firebase/auth
- ActionCodeOperation
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.7 kB 38.8 kB +176 B (+0.5%)
  size-with-ext-deps 59.4 kB 59.6 kB +176 B (+0.3%)
- ActionCodeURL
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.5 kB 39.7 kB +176 B (+0.4%)
  size-with-ext-deps 60.5 kB 60.7 kB +176 B (+0.3%)
- AuthCredential
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.7 kB 38.8 kB +176 B (+0.5%)
  size-with-ext-deps 59.4 kB 59.6 kB +176 B (+0.3%)
- AuthErrorCodes
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.5 kB 43.7 kB +176 B (+0.4%)
  size-with-ext-deps 64.3 kB 64.4 kB +176 B (+0.3%)
- EmailAuthCredential
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 41.3 kB 41.5 kB +176 B (+0.4%)
  size-with-ext-deps 62.1 kB 62.3 kB +176 B (+0.3%)
- EmailAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 42.7 kB 42.9 kB +176 B (+0.4%)
  size-with-ext-deps 63.8 kB 64.0 kB +176 B (+0.3%)
- FacebookAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.5 kB 43.6 kB +176 B (+0.4%)
  size-with-ext-deps 64.3 kB 64.4 kB +176 B (+0.3%)
- FactorId
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- GithubAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.5 kB 43.6 kB +176 B (+0.4%)
  size-with-ext-deps 64.3 kB 64.4 kB +176 B (+0.3%)
- GoogleAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.5 kB 43.6 kB +176 B (+0.4%)
  size-with-ext-deps 64.3 kB 64.4 kB +176 B (+0.3%)
- OAuthCredential
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.6 kB 40.7 kB +176 B (+0.4%)
  size-with-ext-deps 61.3 kB 61.5 kB +176 B (+0.3%)
- OAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.4 kB 44.6 kB +176 B (+0.4%)
  size-with-ext-deps 65.2 kB 65.4 kB +176 B (+0.3%)
- OperationType
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.7 kB +176 B (+0.5%)
  size-with-ext-deps 59.3 kB 59.4 kB +176 B (+0.3%)
- PhoneAuthCredential
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.6 kB 40.7 kB +176 B (+0.4%)
  size-with-ext-deps 61.3 kB 61.5 kB +176 B (+0.3%)
- PhoneAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 42.2 kB 42.4 kB +176 B (+0.4%)
  size-with-ext-deps 63.0 kB 63.2 kB +176 B (+0.3%)
- PhoneMultiFactorGenerator
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.3 kB 39.5 kB +176 B (+0.4%)
  size-with-ext-deps 60.1 kB 60.2 kB +176 B (+0.3%)
- ProviderId
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.7 kB +176 B (+0.5%)
  size-with-ext-deps 59.3 kB 59.5 kB +176 B (+0.3%)
- RecaptchaVerifier
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.6 kB 44.8 kB +176 B (+0.4%)
  size-with-ext-deps 65.4 kB 65.6 kB +176 B (+0.3%)
- SAMLAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.7 kB 44.9 kB +176 B (+0.4%)
  size-with-ext-deps 65.5 kB 65.7 kB +176 B (+0.3%)
- SignInMethod
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.6 kB 38.7 kB +176 B (+0.5%)
  size-with-ext-deps 59.3 kB 59.5 kB +176 B (+0.3%)
- TotpMultiFactorGenerator
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.9 kB 41.1 kB +176 B (+0.4%)
  size-with-ext-deps 61.7 kB 61.9 kB +176 B (+0.3%)
- TotpSecret
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.4 kB 39.6 kB +176 B (+0.4%)
  size-with-ext-deps 60.2 kB 60.3 kB +176 B (+0.3%)
- TwitterAuthProvider
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.5 kB 43.6 kB +176 B (+0.4%)
  size-with-ext-deps 64.3 kB 64.4 kB +176 B (+0.3%)
- applyActionCode
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.7 kB +176 B (+0.5%)
  size-with-ext-deps 59.3 kB 59.5 kB +176 B (+0.3%)
- beforeAuthStateChanged
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.3 kB 59.4 kB +176 B (+0.3%)
- browserLocalPersistence
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 41.8 kB 42.0 kB +176 B (+0.4%)
  size-with-ext-deps 62.7 kB 62.9 kB +176 B (+0.3%)
- browserPopupRedirectResolver
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 62.5 kB 62.7 kB +176 B (+0.3%)
  size-with-ext-deps 83.5 kB 83.6 kB +176 B (+0.2%)
- browserSessionPersistence
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 41.8 kB 42.0 kB +176 B (+0.4%)
  size-with-ext-deps 62.7 kB 62.9 kB +176 B (+0.3%)
- checkActionCode
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.6 kB 39.8 kB +176 B (+0.4%)
  size-with-ext-deps 60.4 kB 60.6 kB +176 B (+0.3%)
- confirmPasswordReset
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.8 kB 39.0 kB +176 B (+0.5%)
  size-with-ext-deps 59.6 kB 59.7 kB +176 B (+0.3%)
- connectAuthEmulator
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.1 kB 40.3 kB +176 B (+0.4%)
  size-with-ext-deps 60.9 kB 61.1 kB +176 B (+0.3%)
- createUserWithEmailAndPassword
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.5 kB 40.6 kB +176 B (+0.4%)
  size-with-ext-deps 61.3 kB 61.4 kB +176 B (+0.3%)
- debugErrorMap
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 50.6 kB 50.8 kB +176 B (+0.3%)
  size-with-ext-deps 71.4 kB 71.6 kB +176 B (+0.2%)
- deleteUser
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- fetchSignInMethodsForEmail
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.8 kB 38.9 kB +176 B (+0.5%)
  size-with-ext-deps 59.5 kB 59.7 kB +176 B (+0.3%)
- getAdditionalUserInfo
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.7 kB 39.9 kB +176 B (+0.4%)
  size-with-ext-deps 60.5 kB 60.7 kB +176 B (+0.3%)
- getAuth
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 72.5 kB 72.7 kB +176 B (+0.2%)
  size-with-ext-deps 100 kB 100 kB +176 B (+0.2%)
- getIdToken
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- getIdTokenResult
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- getMultiFactorResolver
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 41.3 kB 41.5 kB +176 B (+0.4%)
  size-with-ext-deps 62.1 kB 62.3 kB +176 B (+0.3%)
- getRedirectResult
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 46.0 kB 46.1 kB +176 B (+0.4%)
  size-with-ext-deps 66.8 kB 66.9 kB +176 B (+0.3%)
- inMemoryPersistence
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- indexedDBLocalPersistence
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 45.8 kB 46.0 kB +176 B (+0.4%)
  size-with-ext-deps 66.6 kB 66.8 kB +176 B (+0.3%)
- initializeAuth
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.7 kB 38.8 kB +176 B (+0.5%)
  size-with-ext-deps 59.9 kB 60.1 kB +176 B (+0.3%)
- initializeRecaptchaConfig
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.7 kB +176 B (+0.5%)
  size-with-ext-deps 59.3 kB 59.4 kB +176 B (+0.3%)
- isSignInWithEmailLink
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.6 kB 39.8 kB +176 B (+0.4%)
  size-with-ext-deps 60.6 kB 60.8 kB +176 B (+0.3%)
- linkWithCredential
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.4 kB 39.6 kB +176 B (+0.4%)
  size-with-ext-deps 60.2 kB 60.4 kB +176 B (+0.3%)
- linkWithPhoneNumber
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.0 kB 43.2 kB +176 B (+0.4%)
  size-with-ext-deps 63.8 kB 64.0 kB +176 B (+0.3%)
- linkWithPopup
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 49.5 kB 49.7 kB +176 B (+0.4%)
  size-with-ext-deps 70.3 kB 70.5 kB +176 B (+0.3%)
- linkWithRedirect
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.8 kB 44.9 kB +176 B (+0.4%)
  size-with-ext-deps 65.6 kB 65.7 kB +176 B (+0.3%)
- multiFactor
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.6 kB 40.8 kB +176 B (+0.4%)
  size-with-ext-deps 61.4 kB 61.6 kB +176 B (+0.3%)
- onAuthStateChanged
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- onIdTokenChanged
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- parseActionCodeURL
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.5 kB 39.7 kB +176 B (+0.4%)
  size-with-ext-deps 60.6 kB 60.7 kB +176 B (+0.3%)
- prodErrorMap
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- reauthenticateWithCredential
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.0 kB 40.2 kB +176 B (+0.4%)
  size-with-ext-deps 60.8 kB 61.0 kB +176 B (+0.3%)
- reauthenticateWithPhoneNumber
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.5 kB 43.7 kB +176 B (+0.4%)
  size-with-ext-deps 64.3 kB 64.5 kB +176 B (+0.3%)
- reauthenticateWithPopup
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 49.5 kB 49.7 kB +176 B (+0.4%)
  size-with-ext-deps 70.3 kB 70.5 kB +176 B (+0.3%)
- reauthenticateWithRedirect
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.5 kB 44.7 kB +176 B (+0.4%)
  size-with-ext-deps 65.3 kB 65.5 kB +176 B (+0.3%)
- reload
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- sendEmailVerification
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.3 kB 39.5 kB +176 B (+0.4%)
  size-with-ext-deps 60.1 kB 60.3 kB +176 B (+0.3%)
- sendPasswordResetEmail
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.1 kB 40.3 kB +176 B (+0.4%)
  size-with-ext-deps 60.9 kB 61.1 kB +176 B (+0.3%)
- sendSignInLinkToEmail
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 40.2 kB 40.3 kB +176 B (+0.4%)
  size-with-ext-deps 60.9 kB 61.1 kB +176 B (+0.3%)
- setPersistence
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- signInAnonymously
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.6 kB 39.8 kB +176 B (+0.4%)
  size-with-ext-deps 60.4 kB 60.5 kB +176 B (+0.3%)
- signInWithCredential
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.8 kB 40.0 kB +176 B (+0.4%)
  size-with-ext-deps 60.6 kB 60.8 kB +176 B (+0.3%)
- signInWithCustomToken
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.4 kB 39.6 kB +176 B (+0.4%)
  size-with-ext-deps 60.2 kB 60.4 kB +176 B (+0.3%)
- signInWithEmailAndPassword
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.2 kB 44.4 kB +176 B (+0.4%)
  size-with-ext-deps 65.2 kB 65.4 kB +176 B (+0.3%)
- signInWithEmailLink
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.4 kB 44.6 kB +176 B (+0.4%)
  size-with-ext-deps 65.4 kB 65.6 kB +176 B (+0.3%)
- signInWithPhoneNumber
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 43.3 kB 43.5 kB +176 B (+0.4%)
  size-with-ext-deps 64.1 kB 64.3 kB +176 B (+0.3%)
- signInWithPopup
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 49.5 kB 49.7 kB +176 B (+0.4%)
  size-with-ext-deps 70.3 kB 70.5 kB +176 B (+0.3%)
- signInWithRedirect
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 44.2 kB 44.4 kB +176 B (+0.4%)
  size-with-ext-deps 65.0 kB 65.2 kB +176 B (+0.3%)
- signOut
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- unlink
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.0 kB 39.2 kB +176 B (+0.5%)
  size-with-ext-deps 59.8 kB 60.0 kB +176 B (+0.3%)
- updateCurrentUser
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- updateEmail
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.7 kB 38.9 kB +176 B (+0.5%)
  size-with-ext-deps 59.5 kB 59.7 kB +176 B (+0.3%)
- updatePassword
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.7 kB 38.9 kB +176 B (+0.5%)
  size-with-ext-deps 59.5 kB 59.7 kB +176 B (+0.3%)
- updatePhoneNumber
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.2 kB 39.3 kB +176 B (+0.4%)
  size-with-ext-deps 60.0 kB 60.1 kB +176 B (+0.3%)
- updateProfile
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.9 kB 39.1 kB +176 B (+0.5%)
  size-with-ext-deps 59.7 kB 59.9 kB +176 B (+0.3%)
- useDeviceLanguage
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.4 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.2 kB 59.4 kB +176 B (+0.3%)
- validatePassword
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 38.5 kB 38.6 kB +176 B (+0.5%)
  size-with-ext-deps 59.3 kB 59.4 kB +176 B (+0.3%)
- verifyBeforeUpdateEmail
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.4 kB 39.5 kB +176 B (+0.4%)
  size-with-ext-deps 60.2 kB 60.3 kB +176 B (+0.3%)
- verifyPasswordResetCode
  Size
  Type Base (1025840) Merge (3b105d3) Diff
  size 39.7 kB 39.9 kB +176 B (+0.4%)
  size-with-ext-deps 60.5 kB 60.7 kB +176 B (+0.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/xWULA9B1Tg.html

…putted to validatePassword (#7471) * Include the character option statuses even when an empty string is inputted

Include the character option statuses even when an empty string is in…

68e03c3

…putted

ch5zzy commented Jul 17, 2023

View reviewed changes

Update formatting

efcbc06

ch5zzy requested a review from Xiaoshouzi-gh July 17, 2023 20:28

ch5zzy marked this pull request as ready for review July 17, 2023 20:29

ch5zzy requested review from lisajian, prameshj, renkelvin, sam-gc and a team as code owners July 17, 2023 20:29

Xiaoshouzi-gh approved these changes Jul 17, 2023

View reviewed changes

ch5zzy merged commit 5ef98ff into password-policy Jul 17, 2023

ch5zzy deleted the fix-empty-string-password-policy branch July 17, 2023 21:34

ch5zzy added a commit that referenced this pull request Jul 17, 2023

Include the character option statuses even when an empty string is in…

2543f9d

…putted to validatePassword (#7471) * Include the character option statuses even when an empty string is inputted

firebase locked and limited conversation to collaborators Aug 17, 2023

Include the character option statuses even when an empty string is inputted to validatePassword #7471

Include the character option statuses even when an empty string is inputted to validatePassword #7471

Uh oh!

Conversation

ch5zzy commented Jul 17, 2023

Uh oh!

changeset-bot bot commented Jul 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

ch5zzy Jul 17, 2023

Choose a reason for hiding this comment

Uh oh!

google-oss-bot commented Jul 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TotpMultiFactorGenerator

TotpSecret

TwitterAuthProvider

applyActionCode

beforeAuthStateChanged

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

initializeRecaptchaConfig

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

changeset-bot bot commented Jul 17, 2023 •

edited

Loading

google-oss-bot commented Jul 17, 2023 •

edited

Loading

Size Report ¹

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`bundle`

`firebase`

google-oss-bot commented Jul 17, 2023 •

edited

Loading

Size Analysis Report ¹

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TotpMultiFactorGenerator`

`TotpSecret`

`TwitterAuthProvider`

`applyActionCode`

`beforeAuthStateChanged`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`initializeRecaptchaConfig`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`