Skip to content

Re-enable Auth webdriver tests #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 2, 2023
Merged

Re-enable Auth webdriver tests #7797

merged 6 commits into from
Dec 2, 2023

Conversation

renkelvin
Copy link

@renkelvin renkelvin commented Nov 20, 2023 •
edited
Loading

Change test server from localhost to 127.0.0.1 to match emulator host, as they were considered different origins in redirect tests.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e284ee1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 20, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (0ecaf6c) and merge commit (6e72c1c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xp7AK0Yity.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 20, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (0ecaf6c) and merge commit (6e72c1c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WDyVcJOT2z.html

@renkelvin renkelvin changed the title Update oob.local.test.ts Debugging webdriver tests Nov 21, 2023
@renkelvin renkelvin force-pushed the oob-fix branch 3 times, most recently from 7196475 to 339ed43 Compare December 1, 2023 04:11
Revert "Disable all webdriver redirect tests (#7801)"
0276d78 
Revert "Revert "Disable all webdriver redirect tests (#7801)""

This reverts commit d69313e.

Revert "Revert "Revert "Disable all webdriver redirect tests (#7801)"""

This reverts commit 339ed43.
@renkelvin renkelvin marked this pull request as ready for review December 1, 2023 08:18
@renkelvin renkelvin requested review from lisajian, prameshj, sam-gc and a team as code owners December 1, 2023 08:18
@renkelvin renkelvin changed the title Debugging webdriver tests Re-enable Auth webdriver tests and pin Chrome version to 114 Dec 1, 2023
@renkelvin renkelvin changed the title Re-enable Auth webdriver tests and pin Chrome version to 114 Re-enable Auth webdriver tests Dec 1, 2023
prameshj
prameshj approved these changes Dec 1, 2023
View reviewed changes
@renkelvin renkelvin merged commit ac10cc3 into master Dec 2, 2023
@renkelvin renkelvin deleted the oob-fix branch December 2, 2023 01:03
@firebase firebase locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prameshj prameshj prameshj approved these changes

@lisajian lisajian Awaiting requested review from lisajian

@sam-gc sam-gc Awaiting requested review from sam-gc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renkelvin @google-oss-bot @prameshj