Skip to content

Re-enable Auth webdriver tests #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Re-enable Auth webdriver tests #7797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0276d78
Revert "Disable all webdriver redirect tests (#7801)"
Nov 20, 2023
25be10a
revert chrome to 114
Dec 1, 2023
87328fa
Update test_server.ts
Dec 1, 2023
99c6220
Revert "revert chrome to 114"
Dec 1, 2023
776a2fd
Update test_server.ts
Dec 1, 2023
e284ee1
Update test_server.ts
Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/auth/test/integration/webdriver/compat/firebaseui.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,7 @@ browserDescribe('WebDriver integration with FirebaseUI', driver => {
expect(snap.uid).to.be.a('string');
});

it('allows google redirect sign in', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('allows google redirect sign in', async () => {
const page = await startUi();
await page.clickGoogleSignIn();
const widget = new IdPPage(driver.webDriver);
Expand Down
64 changes: 10 additions & 54 deletions packages/auth/test/integration/webdriver/redirect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
await driver.start('chrome');
});

it('allows users to sign in', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('allows users to sign in', async () => {
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
const widget = new IdPPage(driver.webDriver);

Expand Down Expand Up @@ -84,10 +80,6 @@ browserDescribe('WebDriver redirect IdP test', driver => {

// Redirect works with middleware for now
it('is blocked by middleware', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

if (driver.isCompatLayer()) {
console.warn('Skipping middleware tests in compat');
this.skip();
Expand All @@ -114,11 +106,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(await driver.getUserSnapshot()).to.be.null;
});

it('can link with another account account', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('can link with another account account', async () => {
// First, sign in anonymously
const { user: anonUser }: UserCredential = await driver.call(
AnonFunction.SIGN_IN_ANONYMOUSLY
Expand All @@ -140,11 +128,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(user.email).to.eq('[email protected]');
});

it('can be converted to a credential', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('can be converted to a credential', async () => {
// Start with redirect
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
const widget = new IdPPage(driver.webDriver);
Expand Down Expand Up @@ -172,11 +156,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(second.providerData).to.eql(first.providerData);
});

it('handles account exists different credential errors', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('handles account exists different credential errors', async () => {
// Start with redirect and a verified account
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
const widget = new IdPPage(driver.webDriver);
Expand Down Expand Up @@ -211,11 +191,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
]);
});

it('does not auto-upgrade anon accounts', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('does not auto-upgrade anon accounts', async () => {
const { user: anonUser }: UserCredential = await driver.call(
AnonFunction.SIGN_IN_ANONYMOUSLY
);
Expand All @@ -232,11 +208,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(curUser.uid).not.to.eq(anonUser.uid);
});

it('linking with anonymous user upgrades account', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('linking with anonymous user upgrades account', async () => {
const { user: anonUser }: UserCredential = await driver.call(
AnonFunction.SIGN_IN_ANONYMOUSLY
);
Expand All @@ -254,11 +226,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(curUser.isAnonymous).to.be.false;
});

it('is possible to link with different email', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('is possible to link with different email', async () => {
const { user: emailUser }: UserCredential = await driver.call(
EmailFunction.CREATE_USER,
'[email protected]'
Expand All @@ -281,11 +249,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(curUser.providerData.length).to.eq(2);
});

it('is possible to link with the same email', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('is possible to link with the same email', async () => {
const { user: emailUser }: UserCredential = await driver.call(
EmailFunction.CREATE_USER,
'[email protected]'
Expand Down Expand Up @@ -327,11 +291,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
await driver.call(CoreFunction.SIGN_OUT);
});

it('a user can sign in again', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('a user can sign in again', async () => {
// Sign in using pre-poulated user
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);

Expand All @@ -347,11 +307,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(user.email).to.eq(user1.email);
});

it('reauthenticate works for the correct user', async function () {
// Test is ignored for now as it fails.
// TODO: Investigate and unskip the test.
this.skip();

it('reauthenticate works for the correct user', async () => {
// Sign in using pre-poulated user
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);

Expand Down
6 changes: 5 additions & 1 deletion packages/auth/test/integration/webdriver/util/test_server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ class AuthTestServer {
}

get address(): string {
return `http://localhost:${PORT_NUMBER}`;
/*
We use "127.0.0.1" rather than "localhost" since emulator uses the former,
and we want to be on the same origin (to access session storage for redirect-based tests).
*/
return `http://127.0.0.1:${PORT_NUMBER}`;
}

async start(): Promise<void> {
Expand Down