Skip to content

Add GetHttpsCallableFromURL to Functions #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2022
Merged

Add GetHttpsCallableFromURL to Functions #313

merged 4 commits into from
May 25, 2022

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented May 24, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Adds GetHttpsCallableFromURL to the Functions SDK. This was recently added to both the Android and iOS SDKs.


Testing

Describe how you've tested these changes.

Running the integration testapp locally
https://github.com/firebase/firebase-unity-sdk/actions/runs/2379519242


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Will require firebase/firebase-cpp-sdk#964, and updating the firebase_cpp default

@a-maurice a-maurice requested a review from cynthiajoan May 24, 2022 20:48
cynthiajoan
cynthiajoan previously approved these changes May 24, 2022
@a-maurice a-maurice merged commit c93a6a0 into main May 25, 2022
@a-maurice a-maurice deleted the am-functions branch May 25, 2022 18:17
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 25, 2022
@github-actions
Copy link

github-actions bot commented May 25, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit c93a6a0
Last updated: Wed May 25 15:08 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [2019] [macos] [1/5 Platform(s): Android] [android_target]
functions [BUILD] [ERROR] [2019] [macos] [All 3 Platform(s)]
[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Playmode]
messaging [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Android] [android_target]
storage [BUILD] [ERROR] [2019] [macos] [All 3 Platform(s)]
[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Playmode]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 25, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 25, 2022
@a-maurice a-maurice restored the am-functions branch May 26, 2022 00:12
@a-maurice a-maurice deleted the am-functions branch June 7, 2022 00:29
@firebase firebase locked and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants