[flang][OpenMP] Added support for lowering OpenMP barrier construct #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds lowering support for OpenMP barrier construct to OpenMP Dialect operations. In order to support lowering, this patch registers OpenMPDialect and also adds OpenMPDialect to the legalizer.
Unfortunately, we are still upstreaming code. Merging into fir-dev for the moment to eliminate divergence will benefit everyone involved. It allows building, testing, coordinating, and the upstreaming process not to be derailed by creating diverging forks of the code. The good news is that upstreaming is continuing to close the gap. |
schweitzpgi
reviewed
Jul 7, 2020
schweitzpgi
approved these changes
Jul 7, 2020
schweitzpgi
reviewed
Jul 7, 2020
- Replace switch case with individual case statement as per enum. - Modified test case to use tco tool for validating lowering to llvmir.
SouraVX
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 14, 2020
Summary: This patch implements lowering of OpenMP barrier construct from pft to OpenMPDialect. Patch is carved out of following merged PR's from fir-dev branch of https://github.com/flang-compiler/f18-llvm-project/ PR's: flang-compiler#248 flang-compiler#251 Unfortunately primary tool `bbc` for functional validation is not yet upstreamed. So this patch includes a unittest for lowering `!OMP barrier` construct. Some part of the these PR's still remains downstream(functional test and dialect registration to legalizer) for obvious reasons. Will upstream them when the dependencies are upstreamed. Reviewed By: schweitz, kiranchandramohan Differential Revision: https://reviews.llvm.org/D83659
arichardson
pushed a commit
to arichardson/llvm-project
that referenced
this pull request
Jul 15, 2020
Summary: This patch implements lowering of OpenMP barrier construct from pft to OpenMPDialect. Patch is carved out of following merged PR's from fir-dev branch of https://github.com/flang-compiler/f18-llvm-project/ PR's: flang-compiler/f18-llvm-project#248 flang-compiler/f18-llvm-project#251 Unfortunately primary tool `bbc` for functional validation is not yet upstreamed. So this patch includes a unittest for lowering `!OMP barrier` construct. Some part of the these PR's still remains downstream(functional test and dialect registration to legalizer) for obvious reasons. Will upstream them when the dependencies are upstreamed. Reviewed By: schweitz, kiranchandramohan Differential Revision: https://reviews.llvm.org/D83659
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Summary: This patch implements lowering of OpenMP barrier construct from pft to OpenMPDialect. Patch is carved out of following merged PR's from fir-dev branch of https://github.com/flang-compiler/f18-llvm-project/ PR's: flang-compiler/f18-llvm-project#248 flang-compiler/f18-llvm-project#251 Unfortunately primary tool `bbc` for functional validation is not yet upstreamed. So this patch includes a unittest for lowering `!OMP barrier` construct. Some part of the these PR's still remains downstream(functional test and dialect registration to legalizer) for obvious reasons. Will upstream them when the dependencies are upstreamed. Reviewed By: schweitz, kiranchandramohan Differential Revision: https://reviews.llvm.org/D83659
NimishMishra
pushed a commit
to NimishMishra/f18-llvm-project
that referenced
this pull request
Jun 27, 2024
Merge attempt by ../aomp/trunk/merge_from_main.sh into branch amd-trunk-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds lowering support for OpenMP barrier construct to OpenMP Dialect operations.
Since this is the very first patch in this direction, so in order to support lowering, this patch do following infra setup:
registers OpenMPDialect for lowering.
registers OpenMPDialect as a legal Dialect to the legalizer.
Also setup some basic infrastructure to lower other OpenMP constructs. This is in spirit to convey the overall design of lowering to OpenMP Dialect.
Patch is mergeable/upstream, but since upstream flang doesn't have bbc so this can't be validated in upstream. However if community wants we can have review here and merge it in upstream(leaving the test case down stream in this branch).