Fix for #250 #251
Merged
Fix for #250 #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks ok. Let me give it a shot. |
schweitzpgi
approved these changes
Jul 8, 2020
SouraVX
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 14, 2020
Summary: This patch implements lowering of OpenMP barrier construct from pft to OpenMPDialect. Patch is carved out of following merged PR's from fir-dev branch of https://github.com/flang-compiler/f18-llvm-project/ PR's: flang-compiler#248 flang-compiler#251 Unfortunately primary tool `bbc` for functional validation is not yet upstreamed. So this patch includes a unittest for lowering `!OMP barrier` construct. Some part of the these PR's still remains downstream(functional test and dialect registration to legalizer) for obvious reasons. Will upstream them when the dependencies are upstreamed. Reviewed By: schweitz, kiranchandramohan Differential Revision: https://reviews.llvm.org/D83659
arichardson
pushed a commit
to arichardson/llvm-project
that referenced
this pull request
Jul 15, 2020
Summary: This patch implements lowering of OpenMP barrier construct from pft to OpenMPDialect. Patch is carved out of following merged PR's from fir-dev branch of https://github.com/flang-compiler/f18-llvm-project/ PR's: flang-compiler/f18-llvm-project#248 flang-compiler/f18-llvm-project#251 Unfortunately primary tool `bbc` for functional validation is not yet upstreamed. So this patch includes a unittest for lowering `!OMP barrier` construct. Some part of the these PR's still remains downstream(functional test and dialect registration to legalizer) for obvious reasons. Will upstream them when the dependencies are upstreamed. Reviewed By: schweitz, kiranchandramohan Differential Revision: https://reviews.llvm.org/D83659
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Summary: This patch implements lowering of OpenMP barrier construct from pft to OpenMPDialect. Patch is carved out of following merged PR's from fir-dev branch of https://github.com/flang-compiler/f18-llvm-project/ PR's: flang-compiler/f18-llvm-project#248 flang-compiler/f18-llvm-project#251 Unfortunately primary tool `bbc` for functional validation is not yet upstreamed. So this patch includes a unittest for lowering `!OMP barrier` construct. Some part of the these PR's still remains downstream(functional test and dialect registration to legalizer) for obvious reasons. Will upstream them when the dependencies are upstreamed. Reviewed By: schweitz, kiranchandramohan Differential Revision: https://reviews.llvm.org/D83659
NimishMishra
pushed a commit
to NimishMishra/f18-llvm-project
that referenced
this pull request
Jun 27, 2024
Remove CSE and constant folding interfaces used for omp.target Merged per teams discussion. Expected to reduce trunk diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This FIX #250 for time being.
Since after 2ddba30, all the OpenMP directives are clubbed into a common namespace lib::omp. This makes all the eum visible in switch case at flang/lib/Lower/OpenMP.cpp:28.
This patch rolls back the switch case to default based(for not applicable directive in context of OmpSimpleStandaloneDirective).
This is needed otherwise compiler will throw compile time errors for all the unhandled not applicable cases.