[CQ] Nullability: add missing annotations to overrides (#8147)

Addresses a number of places where we're overriding methods that provide
nullability guarantees that we're not respecting in our implementations.
Also removes a few unstable overrides (that were just duplicating super
behavior anyway).


![image](https://github.com/user-attachments/assets/a843b919-b709-4762-b611-b4b45a93a59f)




---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>

Author: pq

flutter-idea/src/io/flutter/FlutterErrorReportSubmitter.java

@@ -51,7 +51,7 @@ public String getReportActionText() {
   }
 
   //@Override
-  public boolean submit(@NotNull IdeaLoggingEvent[] events,
+  public boolean submit(@NotNull IdeaLoggingEvent @NotNull [] events,
                         @Nullable String additionalInfo,
                         @NotNull Component parentComponent,
                         @NotNull Consumer<? super SubmittedReportInfo> consumer) {

flutter-idea/src/io/flutter/project/FlutterProjectOpenProcessor.java

@@ -26,9 +26,8 @@
 public class FlutterProjectOpenProcessor extends ProjectOpenProcessor {
   private static final Logger LOG = Logger.getInstance(FlutterProjectOpenProcessor.class);
 
-  @NotNull
   @Override
-  public String getName() {
+  public @NotNull String getName() {
     return FlutterBundle.message("flutter.module.name");
   }
 

flutter-idea/src/io/flutter/run/FlutterPositionMapper.java

@@ -109,7 +109,8 @@ public FlutterPositionMapper(@NotNull Project project,
 
   @NotNull
   public Project getProject() {
-    return project;
+    // Project may be null after shutdown but clients have no business accessing it after that so it's reasonable to fail here.
+    return Objects.requireNonNull(project);
   }
 
   public void onConnect(@NotNull DartVmServiceDebugProcess.ScriptProvider provider, @Nullable String remoteBaseUri) {
@@ -330,9 +331,10 @@ protected VirtualFile findLocalFile(@NotNull String uri, CompletableFuture<Strin
       if (analyzer != null && !isDartPatchUri(remoteUri)) {
         final String path = analyzer.getAbsolutePath(remoteUri);
         if (path != null) {
-          if(path.startsWith("file://")) {
+          if (path.startsWith("file://")) {
             LocalFileSystem.getInstance().findFileByPath(path.substring(7));
-          } else {
+          }
+          else {
             LocalFileSystem.getInstance().findFileByPath(path);
           }
         }

flutter-idea/src/io/flutter/run/SdkRunConfig.java

@@ -96,7 +96,7 @@ public static class RecursiveDeleter extends SimpleFileVisitor<Path> {
     }
 
     @Override
-    public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
+    public @NotNull FileVisitResult visitFile(Path file, @NotNull BasicFileAttributes attrs) {
       final Path name = file.getFileName();
       if (name != null && matcher.matches(name)) {
         try {
@@ -111,12 +111,12 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
     }
 
     @Override
-    public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) {
+    public @NotNull FileVisitResult preVisitDirectory(@NotNull Path dir, @NotNull BasicFileAttributes attrs) {
       return CONTINUE;
     }
 
     @Override
-    public FileVisitResult visitFileFailed(Path file, IOException exc) {
+    public @NotNull FileVisitResult visitFileFailed(@NotNull Path file, @NotNull IOException exc) {
       FlutterUtils.warn(LOG, exc);
       return CONTINUE;
     }
@@ -199,11 +199,11 @@ public LaunchState getState(@NotNull Executor executor, @NotNull ExecutionEnviro
   }
 
   static @NotNull FlutterApp getFlutterApp(@NotNull ExecutionEnvironment env,
-                                            @NotNull FlutterDevice device,
-                                            Project project,
-                                            Module module,
-                                            RunMode mode,
-                                            GeneralCommandLine command) throws ExecutionException {
+                                           @NotNull FlutterDevice device,
+                                           Project project,
+                                           Module module,
+                                           RunMode mode,
+                                           GeneralCommandLine command) throws ExecutionException {
     final FlutterApp app = FlutterApp.start(env, project, module, mode, device, command,
                                             StringUtil.capitalize(mode.mode()) + "App",
                                             "StopApp");

flutter-idea/src/io/flutter/run/coverage/FlutterCoverageEngine.java

@@ -5,37 +5,28 @@
  */
 package io.flutter.run.coverage;
 
-import com.intellij.coverage.CoverageAnnotator;
-import com.intellij.coverage.CoverageEngine;
-import com.intellij.coverage.CoverageFileProvider;
-import com.intellij.coverage.CoverageRunner;
-import com.intellij.coverage.CoverageSuite;
-import com.intellij.coverage.CoverageSuitesBundle;
+import com.intellij.coverage.*;
 import com.intellij.execution.configurations.RunConfigurationBase;
 import com.intellij.execution.configurations.RunProfile;
 import com.intellij.execution.configurations.WrappingRunConfiguration;
 import com.intellij.execution.configurations.coverage.CoverageEnabledConfiguration;
-import com.intellij.execution.testframework.AbstractTestProxy;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.vfs.VirtualFile;
-import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiFile;
 import com.jetbrains.lang.dart.DartFileType;
 import com.jetbrains.lang.dart.psi.DartFile;
 import io.flutter.FlutterBundle;
 import io.flutter.FlutterUtils;
 import io.flutter.pub.PubRoot;
 import io.flutter.run.test.TestConfig;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.io.File;
 import java.util.HashSet;
-import java.util.List;
 import java.util.Set;
 
-import org.jetbrains.annotations.NotNull;
-import org.jetbrains.annotations.Nullable;
-
 public class FlutterCoverageEngine extends CoverageEngine {
 
   public static FlutterCoverageEngine getInstance() {
@@ -134,16 +125,6 @@ public String getQualifiedName(@NotNull final File outputFile,
     return qualifiedNames;
   }
 
-  @Override
-  public List<PsiElement> findTestsByNames(@NotNull String[] testNames, @NotNull Project project) {
-    return null;
-  }
-
-  @Override
-  public @Nullable String getTestMethodName(@NotNull PsiElement element, @NotNull AbstractTestProxy testProxy) {
-    return null;
-  }
-
   @Override
   public String getPresentableText() {
     return FlutterBundle.message("flutter.coverage.presentable.text");

flutter-idea/third_party/vmServiceDrivers/org/dartlang/vm/service/element/ElementList.java

@@ -2,6 +2,7 @@
 
 import com.google.gson.JsonArray;
 import com.google.gson.JsonObject;
+import org.jetbrains.annotations.NotNull;
 
 import java.util.Iterator;
 
@@ -27,7 +28,7 @@ public boolean isEmpty() {
   }
 
   @Override
-  public Iterator<T> iterator() {
+  public @NotNull Iterator<T> iterator() {
     return new Iterator<T>() {
       int index = 0;
 

flutter-studio/src/io/flutter/actions/OpenAndroidModule.java

@@ -33,7 +33,7 @@
  */
 public class OpenAndroidModule extends OpenInAndroidStudioAction implements DumbAware {
   @Override
-  public void actionPerformed(AnActionEvent e) {
+  public void actionPerformed(@NotNull AnActionEvent e) {
     final VirtualFile projectFile = findProjectFile(e);
     if (projectFile == null) {
       FlutterMessages.showError("Error Opening Android Studio", "Project not found.", e.getProject());

flutter-studio/src/io/flutter/android/AndroidModuleLibraryManager.java

@@ -307,7 +307,7 @@ protected EmbeddedAndroidProject(@NotNull Path filePath) {
 
     static final String TEMPLATE_PROJECT_NAME = "_android";
 
-    public String getLocationHash() {
+    public @NotNull String getLocationHash() {
       return "";
     }
 

flutter-studio/src/io/flutter/editor/FlutterStudioProjectOpenProcessor.java

@@ -11,7 +11,6 @@
 import com.intellij.projectImport.ProjectOpenProcessor;
 import com.intellij.ui.EditorNotifications;
 import io.flutter.FlutterUtils;
-//import io.flutter.project.FlutterProjectCreator;
 import io.flutter.project.FlutterProjectOpenProcessor;
 import io.flutter.pub.PubRoot;
 import io.flutter.utils.FlutterModuleUtils;
@@ -20,7 +19,7 @@
 
 public class FlutterStudioProjectOpenProcessor extends FlutterProjectOpenProcessor {
   @Override
-  public String getName() {
+  public @NotNull String getName() {
     return "Flutter Studio";
   }