Skip to content

[CQ] Nullability: add missing annotations to overrides #8147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented May 1, 2025

Addresses a number of places where we're overriding methods that provide nullability guarantees that we're not respecting in our implementations. Also removes a few unstable overrides (that were just duplicating super behavior anyway).

image


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from jwren May 1, 2025 16:41
@pq pq merged commit 0c1007c into flutter:master May 2, 2025
7 checks passed
@pq pq deleted the cq_nullability_misc branch May 2, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants