Add AS Canary to dev channel #5830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Oct 21, 2021
| @@ -46,8 +46,8 @@ public void xtestLocatesIconCtor() throws Exception { | |||
| assertNotNull(element); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testLocatesCupertinoIconCtor() throws Exception { | |||
| //@Test | |||
jacob314
reviewed
Oct 21, 2021
| @Test | ||
| public void testLocatesCupertinoIconCtor() throws Exception { | ||
| //@Test | ||
| public void xtestLocatesCupertinoIconCtor() throws Exception { |
There was a problem hiding this comment.
is this name change intentional?
There was a problem hiding this comment.
That was a mistake from the PR that is supposed to fix tests. I haven't quite got it working yet, so this needs to be disabled for now.
jacob314
approved these changes
Oct 21, 2021
|
Thanks for the review! Hoping to see this in the next dev channel build this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.