Skip to content

Add AS Canary to dev channel #5830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/presubmit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: [4.2, AF.3.1, AS.211, 2021.2]
version: [AF.3.1, AS.211, 2021.2]
steps:
- name: checkout
uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions docs/building.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ If necessary, install the gs_util command-line utility from
To see a list of all current IntelliJ build pre-reqs:

```shell
$ gsutil ls gs://flutter_infra/flutter/intellij/
$ gsutil ls gs://flutter_infra_release/flutter/intellij/
```

### uploading new artifacts

In order to update or add a new pre-req:

```shell
$ gsutil cp <path-to-archive> gs://flutter_infra/flutter/intellij/
$ gsutil cp <path-to-archive> gs://flutter_infra_release/flutter/intellij/
```
## The plugin tool

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -396,53 +396,6 @@ public void init42(@Nullable ProgressIndicator indicator) {
}
}

public void init41(@Nullable ProgressIndicator indicator) {
boolean finished = false;
try {
//ProjectManagerImpl.initProject(path, this, true, null, null);
Method method = ReflectionUtil
.getDeclaredMethod(ProjectManagerImpl.class, "initProject", Path.class, ProjectImpl.class, boolean.class, Project.class,
ProgressIndicator.class);
assert (method != null);
try {
method.invoke(null, path, this, true, null, null);
}
catch (IllegalAccessException | InvocationTargetException e) {
disableGradleSyncAndNotifyUser();
return;
}
finished = true;
}
finally {
if (!finished) {
TransactionGuard.submitTransaction(this, () -> WriteAction.run(() -> {
if (isDisposed() && !isDisabled.get()) {
Disposer.dispose(this);
}
}));
}
}
}

public void initPre41(@Nullable ProgressIndicator indicator) {
boolean finished = false;
try {
registerComponents((List<IdeaPluginDescriptorImpl>)PluginManagerCore.getLoadedPlugins(), null);
getStateStore().setPath(path, true, null);
super.init(false, indicator);
finished = true;
}
finally {
if (!finished) {
TransactionGuard.submitTransaction(this, () -> WriteAction.run(() -> {
if (isDisposed() && !isDisabled.get()) {
Disposer.dispose(this);
}
}));
}
}
}

private void disableGradleSyncAndNotifyUser() {
final FlutterSettings instance = FlutterSettings.getInstance();
instance.setSyncingAndroidLibraries(false);
Expand Down
Binary file not shown.
28 changes: 14 additions & 14 deletions product-matrix.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
{
"list": [
{
"channel": "stable",
"comments": "IntelliJ 2020.2.3, Android Studio 4.2",
"name": "Android Studio 4.2",
"version": "4.2",
"ideaProduct": "android-studio",
"ideaVersion": "202.6987402",
"baseVersion": "202.7660.26",
"dartPluginVersion": "202.8070",
"sinceBuild": "202.7660.26",
"untilBuild": "202.*"
},
{
"channel": "stable",
"comments": "IntelliJ 2020.3.4, Android Studio 2020.3.1",
Expand All @@ -26,7 +14,7 @@
},
{
"channel": "stable",
"comments": "IntelliJ 2021.1, Android Studio 2021.1.1 Canary 13",
"comments": "IntelliJ 2021.1, Android Studio 2021.1.1 Beta",
"name": "Bumblebee",
"isUnitTestTarget": "true",
"version": "AS.211",
Expand All @@ -46,9 +34,21 @@
"ideaVersion": "212.3724.25",
"baseVersion": "212.4746.92",
"dartPluginVersion": "212.3724.2",
"sinceBuild": "212.3724.25",
"sinceBuild": "212.5457.6",
"untilBuild": "212.*",
"filesToSkip": ["flutter-studio/src/io/flutter/actions/FlutterNewProjectAction.java_stub"]
},
{
"channel": "dev",
"comments": "Android Studio 2021.2 Canary",
"name": "Chipmunk",
"version": "AS.212",
"ideaProduct": "android-studio",
"ideaVersion": "2021.2.1.2",
"baseVersion": "212.5284.40",
"dartPluginVersion": "212.5486",
"sinceBuild": "212.5284.40",
"untilBuild": "212.5284.40"
}
]
}
2 changes: 1 addition & 1 deletion resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<category>Custom Languages</category>
<version>SNAPSHOT</version>
<idea-version since-build="202.7660.26" until-build="211.7727"/>
<idea-version since-build="203.6682.168" until-build="211.7727"/>

<depends>com.intellij.modules.platform</depends>
<depends>com.intellij.modules.lang</depends>
Expand Down
2 changes: 1 addition & 1 deletion src/io/flutter/utils/JxBrowserUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public String getSwingFileName() {
}

public String getDistributionLink(String fileName) {
return "https://storage.googleapis.com/flutter_infra/flutter/intellij/jxbrowser/" + fileName;
return "https://storage.googleapis.com/flutter_infra_release/flutter/intellij/jxbrowser/" + fileName;
}

public String getJxBrowserKey() throws FileNotFoundException {
Expand Down
4 changes: 2 additions & 2 deletions testSrc/unit/io/flutter/editor/FlutterIconLineMarkerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ public void xtestLocatesIconCtor() throws Exception {
assertNotNull(element);
}

@Test
public void testLocatesCupertinoIconCtor() throws Exception {
//@Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

public void xtestLocatesCupertinoIconCtor() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this name change intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a mistake from the PR that is supposed to fix tests. I haven't quite got it working yet, so this needs to be disabled for now.

final PsiElement testIdentifier =
setUpDartElement("main() { IconData(0xe190, fontFamily: 'CupertinoIcons'); }", "IconData", LeafPsiElement.class);
final LineMarkerInfo<?> marker = new FlutterIconLineMarkerProvider().getLineMarkerInfo(testIdentifier, getSdk());
Expand Down
2 changes: 1 addition & 1 deletion tool/plugin/lib/artifact.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class Artifact {

class ArtifactManager {
final String base =
'https://storage.googleapis.com/flutter_infra/flutter/intellij';
'https://storage.googleapis.com/flutter_infra_release/flutter/intellij';

final List<Artifact> artifacts = [];

Expand Down
1 change: 1 addition & 0 deletions tool/plugin/lib/edit.dart
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ void checkAndClearAppliedEditCommands() {
appliedEditCommands.clear();
}

// TODO(messick): Remove edits for AS 4.2 when confident they won't be needed again.
List<EditCommand> editCommands = [
EditAndroidModuleLibraryManager(),
Subst(
Expand Down
6 changes: 3 additions & 3 deletions tool/plugin/test/plugin_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ void main() {
expect(
specs.map((spec) => spec.ideaProduct).toList(),
orderedEquals([
'android-studio',
'android-studio',
'android-studio',
'ideaIC',
'android-studio',
]));
});
});
Expand All @@ -59,10 +59,10 @@ void main() {
expect(
specs.map((spec) => spec.ideaProduct).toList(),
orderedEquals([
'android-studio',
'android-studio',
'android-studio',
'ideaIC',
'android-studio',
]));
});
});
Expand All @@ -75,10 +75,10 @@ void main() {
expect(
specs.map((spec) => spec.ideaProduct).toList(),
orderedEquals([
'android-studio',
'android-studio',
'android-studio',
'ideaIC',
'android-studio',
]));
});
});
Expand Down