✨ Support multiple running instance for inspectors #6772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helin24
approved these changes
May 30, 2023
helin24
approved these changes
May 30, 2023
|
This is going into the next release, too. Thanks! |
Merged
helin24
added a commit
that referenced
this pull request
Jun 8, 2023
We want to add this as an option for users who are experiencing problems with the embedded DevTools window, e.g. #6759. I'm not sure if the JCEF browser will be better for cases that are causing problems in the JxBrowser implementation, but I figure we want to start gathering info on how JCEF performs anyway if we want to eventually move away from JxBrowser and its file downloads. @AlexV525 I've reorganized the management of multiple browsers and content, something you introduced in #6772. I pointed out one spot where I'm not sure if my change will work as expected; if you have a chance, please look over/test and let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6189.
20230531_003339.mp4
Implementation details
Browseris a singleton in the previous implementation. The PR updates it to be stored as a mapping between the tab name (the unique device name) and the browser instance.Contents are also cached to ensure they can be added after removing the empty content.Additional context
FlutterPerformanceViewshould be able to apply the same update but I didn't investigate it yet.Pre-launch Checklist
///).