Add JCEF browser #6787
Merged
Add JCEF browser #6787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helin24
commented
Jun 7, 2023
|
The Dart plugin version needs to be updated in line 74 of |
AlexV525
reviewed
Jun 8, 2023
AlexV525
approved these changes
Jun 8, 2023
stevemessick
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
LGTM after making the change @AlexV525 suggested (delete the period), and updating the Dart plugin version.
stevemessick
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
LGTM after making the change @AlexV525 suggested (delete the period), and updating the Dart plugin version.
stevemessick
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
LGTM after making the change @AlexV525 suggested (delete the period), and updating the Dart plugin version.
stevemessick
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
LGTM after making the change @AlexV525 suggested (delete the period), and updating the Dart plugin version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add this as an option for users who are experiencing problems with the embedded DevTools window, e.g. #6759. I'm not sure if the JCEF browser will be better for cases that are causing problems in the JxBrowser implementation, but I figure we want to start gathering info on how JCEF performs anyway if we want to eventually move away from JxBrowser and its file downloads.
@AlexV525 I've reorganized the management of multiple browsers and content, something you introduced in #6772. I pointed out one spot where I'm not sure if my change will work as expected; if you have a chance, please look over/test and let me know.