Refactor original code to remove reference to Abstract Base Class #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this pull request should remove references to Python 3 only code, ie ABC and abstractmethod, that are not available in CircuitPython. This pull request deletes an extraneous file introduced in earlier pull requests. |
adafruit-adabot
added a commit
to adafruit/CircuitPython_Community_Bundle
that referenced
this pull request
Nov 11, 2021
Updating https://github.com/fourstix/Sparkfun_CircuitPython_SerLCD to 1.0.2 from 1.0.1: > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#13 from fourstix/fourstix-patch-1 > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#12 from fourstix/b_refactor > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#9 from PaulskPt/branch_psk > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#6 from mitag/NoAbstracts > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#2 from mcauser/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract Base Class is available in Python 3 but not Circuit Python. There have been some pull requests to address this, but they introduced some side issues. This PR refactors the original code to address these issues and the original issues. References to ABC and abstractmethod are removed from the code, keeping the changes to a minimum.