Skip to content

Removal of all abstract classes for microcontrollers #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

Removal of all abstract classes for microcontrollers #6

merged 1 commit into from
Sep 16, 2021

Conversation

fourstix
Copy link
Owner

Merge in the work done by Mitag. Many thanks for refactoring the code to remove the Abstract Base Class.

fourstix
fourstix commented Sep 16, 2021
View reviewed changes
Copy link
Owner Author

@fourstix fourstix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for doing this, Mitag!

@fourstix fourstix merged commit ba6a131 into fourstix:master Sep 16, 2021
adafruit-adabot added a commit to adafruit/CircuitPython_Community_Bundle that referenced this pull request Nov 11, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@628f852)
6bac504 
Updating https://github.com/fourstix/Sparkfun_CircuitPython_SerLCD to 1.0.2 from 1.0.1:
  > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#13 from fourstix/fourstix-patch-1
  > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#12 from fourstix/b_refactor
  > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#9 from PaulskPt/branch_psk
  > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#6 from mitag/NoAbstracts
  > Merge pull request fourstix/Sparkfun_CircuitPython_SerLCD#2 from mcauser/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fourstix @mitag