Skip to content

feat(electron): Disable sessions now autoSessionTracking has been removed #12655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 10, 2025

When v6 of the Electron SDK is releases, autoSessionTracking has been removed so sessions can be disabled by filtering out the session integration.

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:00am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 0:00am
develop-docs ⬜️ Ignored (Inspect) Feb 11, 2025 0:00am

Copy link

codecov bot commented Feb 10, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.71MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.37MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.83kB -0.0%
static/chunks/7801-*.js -3 bytes 390.91kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/P-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/P-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/7_0-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/7_0-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 968.36kB -0.0%
9523.js -3 bytes 944.56kB -0.0%

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

andreiborza added a commit that referenced this pull request Feb 17, 2025
andreiborza added a commit that referenced this pull request Feb 17, 2025
andreiborza added a commit that referenced this pull request Feb 17, 2025
* ref(v9): Remove v9 todos

* Undo electron changes in favor of #12655

* Explain how to disable sending sessions in the node SDK
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this out of draft and merge in?

@timfish timfish marked this pull request as ready for review February 20, 2025 14:21
@timfish
Copy link
Collaborator Author

timfish commented Feb 20, 2025

Ready to merge!

@coolguyzone coolguyzone merged commit 9cd7e5f into master Feb 20, 2025
11 checks passed
@coolguyzone coolguyzone deleted the timfish/feat/electron-disable-sessions branch February 20, 2025 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants