-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(v9): Remove v9 todos #12740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(v9): Remove v9 todos #12740
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
dff5f80
to
2ca2f01
Compare
I've already had a PR for this for Electron but was waiting for the next major to be released before it gets merged: |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
@timfish ah, didn't see. Also missed that the major wasn't released yet. Will remove these from my pr :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a concern RE removing the autoSessionTracking
note
|
||
{/* We don't use platform links here because we always have to link to node and browser here and doing a conditional just for that feels overkill. */} | ||
|
||
Starting with SDK version 8.43.0 and up, the `autoSessionTracking` option has been deprecated. You can use the [BrowserSession integration](/platforms/javascript/configuration/integrations/browsersession/) in browser environments and the [Http integration](/platforms/javascript/guides/node/configuration/integrations/http/) (via the `trackIncomingRequestsAsSessions` option) in Node.js runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, autoSessionTracking
is no longer available but we still mention it above. I'm not 100% familiar with the replacement but my guess is we should document the httpIntegration option mentioned in the deprecation notice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I updated the docs according to the migration guide.
11c45d3
to
5051bae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
Closes: getsentry/sentry-javascript#14325