Skip to content

ref(v9): Remove v9 todos #12740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025
Merged

ref(v9): Remove v9 todos #12740

merged 3 commits into from
Feb 17, 2025

Conversation

andreiborza
Copy link
Member

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 0:05am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 0:05am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 0:05am

@timfish
Copy link
Collaborator

timfish commented Feb 17, 2025

I've already had a PR for this for Electron but was waiting for the next major to be released before it gets merged:

Copy link

codecov bot commented Feb 17, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/F6lNi4ZK1LN0EZI6JutXh/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/F6lNi4ZK1LN0EZI6JutXh/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/lSmDpJFe3iAslVG9SX7VD/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/lSmDpJFe3iAslVG9SX7VD/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%

@andreiborza
Copy link
Member Author

@timfish ah, didn't see. Also missed that the major wasn't released yet. Will remove these from my pr :)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a concern RE removing the autoSessionTracking note


{/* We don't use platform links here because we always have to link to node and browser here and doing a conditional just for that feels overkill. */}

Starting with SDK version 8.43.0 and up, the `autoSessionTracking` option has been deprecated. You can use the [BrowserSession integration](/platforms/javascript/configuration/integrations/browsersession/) in browser environments and the [Http integration](/platforms/javascript/guides/node/configuration/integrations/http/) (via the `trackIncomingRequestsAsSessions` option) in Node.js runtime.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, autoSessionTracking is no longer available but we still mention it above. I'm not 100% familiar with the replacement but my guess is we should document the httpIntegration option mentioned in the deprecation notice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I updated the docs according to the migration guide.

@andreiborza andreiborza requested a review from Lms24 February 17, 2025 14:54
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@andreiborza andreiborza merged commit 8a06050 into master Feb 17, 2025
11 checks passed
@andreiborza andreiborza deleted the ab/remove-todo-v9 branch February 17, 2025 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9] Go through TODO(v9) comments in docs
3 participants