Skip to content

fixed some android snippets and bumped sentry-java #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2020

Conversation

marandaneto
Copy link
Contributor

No description provided.

wizard:
- _documentation/clients/java/integrations.md#android
- _documentation/platforms/android/#integrating-the-sdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look for places where wizard: true
I think this is how it works now.
Compare to php or something else.

Also there is <!— Wizard android —> double check so we are not missing something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit lost here, not sure how to test it either, all versions (other platforms) are a bit different and this one was a client/integration and now its own platform.
how do I test it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My environment is in an inoperable state currently so I can't verify this for you, but to compile this, run:

JEKYLL_ENABLE_PLATFORM_API=true bin/server

Check the output of _site for a folder called _platforms and then look to see if your new stuff exists in there. This is one of the most opaque parts of the docs, so it's difficult to deal with. Code is here: https://github.com/getsentry/sentry-docs/blob/master/src/_plugins/platform_api.rb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tips, the command didn't work though :(
NoMethodError: undefined method content' for nil:NilClass`
I'll merge without the wizard and figure it out later on, thanks

@marandaneto marandaneto changed the title added new android wizard added new android wizard and versions Feb 13, 2020
@MimiDumpling
Copy link
Contributor

@marandaneto Let me know if Cameron's suggestion works. If not, we can still deploy the docs without the wizard and add the wizard later.

@marandaneto marandaneto changed the title added new android wizard and versions fixed some android snippets and bumped sentry-java Feb 14, 2020
@marandaneto marandaneto merged commit b75f288 into update/mimi-android Feb 14, 2020
@marandaneto marandaneto deleted the feat/android_wizard branch February 14, 2020 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants