chore: Update android wizard link #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Mar 3, 2020
| @@ -93,10 +93,10 @@ | |||
| support_level: production | |||
| type: framework | |||
| name: Android | |||
| doc_link: /clients/java/modules/android/ | |||
| doc_link: /platforms/android/ | |||
| wizard_parent: java | |||
There was a problem hiding this comment.
wizard_parent: java I don't know what it is used for, but moving away from the java client to its own platform, this line seems wrong
There was a problem hiding this comment.
I think this is not really relevant, only for the code parts that we have spread everywhere.
marandaneto
reviewed
Mar 3, 2020
| wizard_parent: java | ||
| wizard: | ||
| - _documentation/clients/java/integrations.md#android | ||
| - _documentation/platforms/android/index.md |
There was a problem hiding this comment.
this file didn't have any changes, and afaik, we'd need to add something like <!— Wizard android —> into it.
See: #1498 (comment)
so that's the way of how the wizard would extract the right piece of code from the whole md file
marandaneto
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
@HazAT I've added 2 comments, if they don't make sense to you, consider it approved :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is correct, goal should be that the onboarding wizard uses the new android docs.