Skip to content

New Koa configuration #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2020
Merged

New Koa configuration #1804

merged 4 commits into from
Jun 29, 2020

Conversation

arthurM2x
Copy link
Contributor

Includes domain creation for better breadcrumbs handling and creation of transaction per request

Includes domain creation for better breadcrumbs handling and creation of transaction per request
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor whitespace issues that I found when running your branch locally.

@dashed
Copy link
Member

dashed commented Jun 29, 2020

@arthurM2x You may need to update the jest snapshots by running yarn test -u.

Thanks for adding this example 👍 I was able to run the example locally.

@arthurM2x
Copy link
Contributor Author

@dashed looks like I don't need to update snapshots?

@dashed
Copy link
Member

dashed commented Jun 29, 2020

@arthurM2x you're right. Looks like the travis checks weren't happy about the whitespace issues.

Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these docs! 👏

@dashed dashed merged commit 336e57b into getsentry:master Jun 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants