-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New Koa configuration #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Koa configuration #1804
Conversation
Includes domain creation for better breadcrumbs handling and creation of transaction per request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor whitespace issues that I found when running your branch locally.
src/collections/_documentation/performance-monitoring/configuration/koa.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/koa.md
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/koa.md
Outdated
Show resolved
Hide resolved
@arthurM2x You may need to update the jest snapshots by running Thanks for adding this example 👍 I was able to run the example locally. |
…ation/koa.md Co-authored-by: Alberto Leal <[email protected]>
…ation/koa.md Co-authored-by: Alberto Leal <[email protected]>
…ation/koa.md Co-authored-by: Alberto Leal <[email protected]>
@dashed looks like I don't need to update snapshots? |
@arthurM2x you're right. Looks like the travis checks weren't happy about the whitespace issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these docs! 👏
Includes domain creation for better breadcrumbs handling and creation of transaction per request