feat: JS performance docs #2133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/m2l7d8xpb/sentry.dev |
PeloWriter
approved these changes
Sep 1, 2020
|
|
||
| - **[Performance](./performance/)** | ||
|
|
||
| Learn more about how to configure Performance for the JavaScript SDK. It provides examples of more advanced use cases. |
There was a problem hiding this comment.
Suggested change
| Learn more about how to configure Performance for the JavaScript SDK. It provides examples of more advanced use cases. | |
| Learn more about how to configure Performance for the JavaScript SDK, including examples of more advanced use cases. |
| ### Manual Instrumentation | ||
|
|
||
| To manually instrument certain regions of your code, you can create a transaction to capture them. | ||
| This is valid for both JavaScript Browser and Node and works independently of the `BrowserTracing` integration. |
There was a problem hiding this comment.
Suggested change
| This is valid for both JavaScript Browser and Node and works independently of the `BrowserTracing` integration. | |
| This is valid for both the JavaScript Browser and Node SDKS, and works independently of the `BrowserTracing` integration. |
| transaction.finish(); // Finishing the transaction will send it to Sentry | ||
| ``` | ||
|
|
||
| Here is a different example. If you want to create a transaction for a user interaction on your page, you need to do the following: |
There was a problem hiding this comment.
Suggested change
| Here is a different example. If you want to create a transaction for a user interaction on your page, you need to do the following: | |
| This example creates a transaction for a user interaction on your page: |
|
@HazAT getsentry/sentry-javascript#2867 is merged, so this should be good to go now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moved part of the JS specific performance documentation into the JavaScript section.
To make what's written in the
Filter out unwanted Spanssection 100% true, we need to release this PR first.getsentry/sentry-javascript#2867