Skip to content

feat(billing): Update documentation surrounding on-demand budgets #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 4, 2022

Conversation

dashed
Copy link
Member

@dashed dashed commented Mar 7, 2022

This pull request updates the current on-demand budget documentation in anticipation of the rollout of the new on-demand budgets feature to all performance plans on the week of April 4, 2022. This pull request should not be merged until this roll out completes.

Changelog:

  • I've renamed "On-Demand Spending Cap" to "On-Demand Budget"
  • Added blurbs on shared and per-category on-demand budget strategies.

@dashed dashed requested review from imatwawana and a team March 7, 2022 22:51
@dashed dashed self-assigned this Mar 7, 2022
@vercel
Copy link

vercel bot commented Mar 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/DasEvrLtKHiJdShtFEW2PjZrwExx
✅ Preview: https://sentry-docs-git-alberto-ondemand-budgets.sentry.dev

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some wording and style edits that should improve clarity, but overall, it's solid.

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more wording fixes.

@dashed
Copy link
Member Author

dashed commented Mar 9, 2022

@imatwawana Let me know if I missed any suggested feedback you had. Can you check the latest changes again?

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

If you opted out of the Early Adopter program while on the per-category on-demand budget strategy, you will still retain this on-demand budget until you switch to the shared on-demand budget strategy.
Customers on plans without performance monitoring can only use the shared on-demand budget strategy.

</Note>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imatwawana There are changes to how the new on-demand budget feature will be rolled out. We aim to roll this out to customers on the performance plan, and are also on the early adopters program.

In addition, if they are using the per-category on-demand budget strategy, they'll retain this configuration regardless if they are on the Early Adopters program or not.

I updated this note to reflect that. I'm unsure if the language here is sufficient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say they'll retain the configuration, do we mean that they just retain the per-category budget they've already set up? Or could they make changes to their per-category budget?

And if they switch to shared, I assume we mean that they can't go back to per-category?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imatwawana

When you say they'll retain the configuration, do we mean that they just retain the per-category budget they've already set up? Or could they make changes to their per-category budget?

They'll be able to do both.

So if they:

  1. enabled early adopters feature in the past,
  2. switched to per-category on-demand budget strategy, and
  3. opted out of early adopters afterwards,

they remain on the per-category on-demand budget.

Customers on the performance plans may only be able to opt into per-category on-demand budget only if they're opted into the Early Adopter program.

And if they switch to shared, I assume we mean that they can't go back to per-category?

They'll be unable to switch back to per-category as long as they're opted out of Early Adopters.

@dashed dashed merged commit ea72efc into master Apr 4, 2022
@dashed dashed deleted the alberto/ondemand-budgets branch April 4, 2022 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants