feat: Update hapi to v8.0.0-rc.1 #28
Conversation
s1gr1d
changed the title
| @@ -13,7 +13,7 @@ | |||
| "sample_rate": "1", | |||
| "sampled": "true", | |||
| "trace_id": "[[ID2]]", | |||
| "transaction": "/test-error" | |||
There was a problem hiding this comment.
v7 does not include the http method
There was a problem hiding this comment.
yeah, this is def. better in v8! 🚀
| "method": "GET", | ||
| "url": "http://localhost:3030/test-error" |
There was a problem hiding this comment.
This is missing in all v7 files.
| @@ -13,7 +13,7 @@ | |||
| "sample_rate": "1", | |||
| "sampled": "true", | |||
| "trace_id": "[[ID2]]", | |||
| "transaction": "/test-param-error/{param}" | |||
| "transaction": "GET /test-param-error/1337" | |||
There was a problem hiding this comment.
getsentry/sentry-javascript#11906 This should probably fix that @mydea
| "op": "http.server", | ||
| "origin": "auto.http.otel.http", |
There was a problem hiding this comment.
op and origin are different
s1gr1d
changed the title
| @@ -13,7 +13,7 @@ | |||
| "sample_rate": "1", | |||
| "sampled": "true", | |||
| "trace_id": "[[ID2]]", | |||
| "transaction": "/test-param-error/{param}" | |||
| "transaction": "GET /test-param-error/1337" | |||
There was a problem hiding this comment.
The error event does not get parameterized in rc.1. @mydea
There was a problem hiding this comment.
hmm that is... not ideal! Could you look into this? Also cc @Lms24 (when you're back from vacation) as you worked on these things before - ideally we can figure this out before v8 stable goes out, but other than this should not block us either!
No description provided.