-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Update hapi to v8.0.0-rc.1 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e1d6b87
hapi v8
s1gr1d ec7dd82
upgrade hapi to rc.1
s1gr1d 8338a05
hapi with instrumentation file
s1gr1d 75d0f93
feat(hapi): Upgrade sentry to v8
s1gr1d 55701f8
Merge branch 'refs/heads/main' into sig/hapi-v8
s1gr1d 20bd14b
update yarn lock
s1gr1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
"event_id": "[[ID1]]", | ||
"sdk": { | ||
"name": "sentry.javascript.node", | ||
"version": "7.113.0" | ||
"version": "8.0.0-beta.6" | ||
}, | ||
"sent_at": "[[ISODateString]]", | ||
"trace": { | ||
|
@@ -13,7 +13,7 @@ | |
"sample_rate": "1", | ||
"sampled": "true", | ||
"trace_id": "[[ID2]]", | ||
"transaction": "/test-error" | ||
"transaction": "GET /test-error" | ||
} | ||
}, | ||
{ | ||
|
@@ -26,18 +26,6 @@ | |
"level": "log", | ||
"message": "Server running on http://localhost:3030", | ||
"timestamp": "[[timestamp]]" | ||
}, | ||
{ | ||
"category": "console", | ||
"level": "log", | ||
"message": "test console", | ||
"timestamp": "[[timestamp]]" | ||
}, | ||
{ | ||
"category": "console", | ||
"level": "log", | ||
"message": "test console", | ||
"timestamp": "[[timestamp]]" | ||
} | ||
], | ||
"contexts": { | ||
|
@@ -70,13 +58,6 @@ | |
"version": "v20.12.1" | ||
}, | ||
"trace": { | ||
"data": { | ||
"sentry.op": "hapi.request", | ||
"sentry.origin": "manual", | ||
"sentry.sample_rate": 1 | ||
}, | ||
"op": "hapi.request", | ||
"origin": "manual", | ||
"span_id": "[[ID3]]", | ||
"trace_id": "[[ID2]]" | ||
} | ||
|
@@ -179,7 +160,7 @@ | |
"filename": "[[FILENAME3]]", | ||
"function": "handler", | ||
"in_app": true, | ||
"lineno": 71, | ||
"lineno": 72, | ||
"module": "app", | ||
"post_context": [ | ||
" var exceptionId;", | ||
|
@@ -233,7 +214,7 @@ | |
"colno": 71, | ||
"context_line": " step((generator = generator.apply(thisArg, _arguments || [])).next());", | ||
"filename": "[[FILENAME3]]", | ||
"function": "<anonymous>", | ||
"function": "?", | ||
"in_app": true, | ||
"lineno": 8, | ||
"module": "app", | ||
|
@@ -314,9 +295,9 @@ | |
"colno": 71, | ||
"context_line": " exceptionId = Sentry.captureException(new Error('This is an error'));", | ||
"filename": "[[FILENAME3]]", | ||
"function": "<anonymous>", | ||
"function": "?", | ||
"in_app": true, | ||
"lineno": 76, | ||
"lineno": 77, | ||
"module": "app", | ||
"post_context": [ | ||
" return [4 /*yield*/, Sentry.flush(2000)];", | ||
|
@@ -345,10 +326,44 @@ | |
] | ||
}, | ||
"modules": { | ||
"localforage": "1.10.0", | ||
"mime-db": "1.52.0" | ||
"debug": "4.3.4", | ||
"dotenv": "16.4.5", | ||
"function-bind": "1.1.2", | ||
"hasown": "2.0.2", | ||
"import-in-the-middle": "1.7.1", | ||
"is-core-module": "2.13.1", | ||
"mime-db": "1.52.0", | ||
"module-details-from-path": "1.0.3", | ||
"opentelemetry-instrumentation-fetch-node": "1.2.0", | ||
"require-in-the-middle": "7.3.0", | ||
"resolve": "1.22.8", | ||
"semver": "7.6.0", | ||
"shimmer": "1.2.1", | ||
"supports-color": "5.5.0", | ||
"yallist": "4.0.0" | ||
}, | ||
"platform": "node", | ||
"request": { | ||
"cookies": {}, | ||
"headers": { | ||
"accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8", | ||
"accept-encoding": "gzip, deflate, br", | ||
"accept-language": "en-US,en;q=0.5", | ||
"cache-control": "no-cache", | ||
"connection": "keep-alive", | ||
"dnt": "1", | ||
"host": "localhost:3030", | ||
"pragma": "no-cache", | ||
"sec-fetch-dest": "document", | ||
"sec-fetch-mode": "navigate", | ||
"sec-fetch-site": "none", | ||
"sec-fetch-user": "?1", | ||
"upgrade-insecure-requests": "1", | ||
"user-agent": "[[user-agent]]" | ||
}, | ||
"method": "GET", | ||
"url": "http://localhost:3030/test-error" | ||
Comment on lines
+350
to
+351
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is missing in all v7 files. |
||
}, | ||
"sdk": { | ||
"integrations": [ | ||
"InboundFilters", | ||
|
@@ -357,28 +372,38 @@ | |
"RequestData", | ||
"Console", | ||
"Http", | ||
"Undici", | ||
"NodeFetch", | ||
"OnUncaughtException", | ||
"OnUnhandledRejection", | ||
"ContextLines", | ||
"LocalVariables", | ||
"LocalVariablesAsync", | ||
"Context", | ||
"Modules", | ||
"Hapi" | ||
"Express", | ||
"Fastify", | ||
"Graphql", | ||
"Mongo", | ||
"Mongoose", | ||
"Mysql", | ||
"Mysql2", | ||
"Redis", | ||
"Postgres", | ||
"Nest", | ||
"Hapi", | ||
"Koa", | ||
"Connect" | ||
], | ||
"name": "sentry.javascript.node", | ||
"packages": [ | ||
{ | ||
"name": "npm:@sentry/node", | ||
"version": "7.113.0" | ||
"version": "8.0.0-beta.6" | ||
} | ||
], | ||
"version": "7.113.0" | ||
"version": "8.0.0-beta.6" | ||
}, | ||
"server_name": "D9M3PY4LQ7.local", | ||
"tags": { | ||
"transaction": "/test-error" | ||
}, | ||
"timestamp": "[[timestamp]]" | ||
"timestamp": "[[timestamp]]", | ||
"transaction": "GET /test-error" | ||
} | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v7 does not include the http method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is def. better in v8! 🚀