Skip to content

Commit 30db115

Browse files
authored
chore(tests): Remove --detectOpenHandles from Jest config. (#11148)
Ref: #11107 Removes `--detectOpenHandles` from Jest configurations of Remix and Next.JS which apparently causes segfault. Re-enables Remix Node 16 and Node 18 integration tests on CI
1 parent 093531e commit 30db115

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -906,16 +906,14 @@ jobs:
906906
strategy:
907907
fail-fast: false
908908
matrix:
909-
# For whatever reason, these segfault on Node 18, so we are skipping these for now...
910-
node: [20, 21]
909+
node: [18, 20, 21]
911910
remix: [1, 2]
912911
# Remix v2 only supports Node 18+, so run Node 14, 16 tests separately
913912
include:
914913
- node: 14
915914
remix: 1
916-
# For whatever reason, these segfault on Node 16, so we are skipping these for now...
917-
# - node: 16
918-
# remix: 1
915+
- node: 16
916+
remix: 1
919917
steps:
920918
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
921919
uses: actions/checkout@v4

packages/nextjs/test/integration/jest.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ module.exports = {
44
...baseConfig,
55
testMatch: [`${__dirname}/test/server/**/*.test.ts`],
66
testPathIgnorePatterns: [`${__dirname}/test/client`],
7-
detectOpenHandles: true,
87
forceExit: true,
98
testTimeout: 30000,
109
setupFilesAfterEnv: [`${__dirname}/jest.setup.js`],

packages/nextjs/test/integration/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"start": "next start",
99
"pretest": "yarn build",
1010
"test:client": "playwright test",
11-
"test:server": "jest --detectOpenHandles --forceExit --runInBand"
11+
"test:server": "jest --forceExit --runInBand"
1212
},
1313
"dependencies": {
1414
"@sentry/nextjs": "file:../../",

packages/remix/test/integration/jest.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@ module.exports = {
44
...baseConfig,
55
testMatch: [`${__dirname}/test/server/**/*.test.ts`],
66
testPathIgnorePatterns: [`${__dirname}/test/client`],
7-
detectOpenHandles: true,
87
forceExit: true,
98
};

0 commit comments

Comments
 (0)