Skip to content

chore(tests): Remove --detectOpenHandles from Jest config. #11148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2024
Merged

chore(tests): Remove --detectOpenHandles from Jest config. #11148

merged 1 commit into from
Mar 18, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Ref: #11107

Removes --detectOpenHandles from Jest configurations of Remix and Next.JS which apparently causes segfault.

Re-enables Remix Node 16 and Node 18 integration tests on CI

@onurtemizkan onurtemizkan force-pushed the onur/fix-jest-segfaults branch from be856ec to 7a6549d Compare March 17, 2024 15:53
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.19 KB (added)
@sentry/browser (incl. Tracing, Replay) 73.52 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 77.33 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.07 KB (added)
@sentry/browser (incl. Tracing) 38.15 KB (added)
@sentry/browser (incl. browserTracingIntegration) 38.15 KB (added)
@sentry/browser (incl. feedbackIntegration) 33.01 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 33.09 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 33.1 KB (added)
@sentry/browser (incl. sendFeedback) 29.08 KB (added)
@sentry/browser 24.25 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.57 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.43 KB (added)
CDN Bundle (incl. Tracing) 37.77 KB (added)
CDN Bundle 25.62 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.88 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 113.82 KB (added)
CDN Bundle - uncompressed 75.66 KB (added)
@sentry/react (incl. Tracing, Replay) 73.51 KB (added)
@sentry/react 24.27 KB (added)

@onurtemizkan onurtemizkan marked this pull request as ready for review March 17, 2024 17:12
Lms24
Lms24 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lms24 Lms24 merged commit 30db115 into develop Mar 18, 2024
@Lms24 Lms24 deleted the onur/fix-jest-segfaults branch March 18, 2024 13:01
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@onurtemizkan @cadesalaberry
chore(tests): Remove --detectOpenHandles from Jest config. (getsent…
6348572 
…ry#11148)

Ref: getsentry#11107

Removes `--detectOpenHandles` from Jest configurations of Remix and
Next.JS which apparently causes segfault.

Re-enables Remix Node 16 and Node 18 integration tests on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @Lms24