Skip to content

ref: Remove tracingOrigins options #10614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Feb 12, 2024

Removes all of the deprecated tracingOrigin APIs and related logic. It is superseded by tracePropagationTargets.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.79 KB (-0.21% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.97 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.66 KB (-0.22% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.23 KB (-0.44% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.11 KB (-0.38% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser - Webpack (gzipped) 22.43 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.04 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.56 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.54 KB (-0.15% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.64 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.74 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.36 KB (-0.19% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.83 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.79 KB (-0.12% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.41 KB (-0.21% 🔽)
@sentry/react - Webpack (gzipped) 22.46 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.05 KB (-0.31% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.31 KB (-0.25% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (0%)

@lforst lforst changed the title ref: Remove tracingOrigins API ref: Remove tracingOrigins options Feb 13, 2024
@lforst lforst marked this pull request as ready for review February 13, 2024 09:58
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad February 13, 2024 09:58
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So good to see these backwards compatibility strategy bytes finally removed 🚀

@@ -1,5 +1,11 @@
# Upgrading from 7.x to 8.x

## Removal of the `tracingOrigins` option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This likely needs to be rewritten since we're removing BrowserTracing completely anyway but for now it's okay. Was just worried because we didn't mention that we removed tracePropaagationTargets in the BrowserTracing options but realized it's not gonna matter 😅

@lforst lforst merged commit 0e7ab1e into develop Feb 13, 2024
@lforst lforst deleted the lforst-remove-tracing-origins branch February 13, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants