-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref: Remove tracingOrigins
options
#10614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4be5c1b
c0c4857
cdad31b
0cdfe8a
ab9ee76
9b6ac7f
643efff
bec628f
6d71b39
f9eb3ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
import { Integrations } from '@sentry/tracing'; | ||
|
||
window.Sentry = Sentry; | ||
window.Replay = new Sentry.Replay({ | ||
|
@@ -11,7 +10,8 @@ window.Replay = new Sentry.Replay({ | |
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [new Integrations.BrowserTracing({ tracingOrigins: [/.*/] }), window.Replay], | ||
integrations: [Sentry.browserTracingIntegration(), window.Replay], | ||
tracePropagationTargets: [/.*/], | ||
environment: 'production', | ||
tracesSampleRate: 1, | ||
// Needs manual start! | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ window.Sentry = Sentry; | |
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [Sentry.browserTracingIntegration({ tracePropagationTargets: ['http://example.com'] })], | ||
integrations: [Sentry.browserTracingIntegration()], | ||
tracePropagationTargets: ['http://example.com'], | ||
tracesSampleRate: 1, | ||
}); |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
import { Integrations } from '@sentry/tracing'; | ||
|
||
window.Sentry = Sentry; | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [new Integrations.BrowserTracing({ tracePropagationTargets: ['http://example.com'] })], | ||
integrations: [Sentry.browserTracingIntegration()], | ||
tracePropagationTargets: ['http://example.com'], | ||
tracesSampleRate: 1, | ||
}); |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
import { Integrations } from '@sentry/tracing'; | ||
|
||
window.Sentry = Sentry; | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [new Integrations.BrowserTracing()], | ||
integrations: [Sentry.browserTracingIntegration()], | ||
tracesSampleRate: 1, | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
import { Integrations } from '@sentry/tracing'; | ||
|
||
window.Sentry = Sentry; | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [new Integrations.BrowserTracing({ tracingOrigins: [/.*/] })], | ||
integrations: [Sentry.browserTracingIntegration()], | ||
tracePropagationTargets: [/.*/], | ||
environment: 'production', | ||
tracesSampleRate: 1, | ||
debug: true, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ window.Sentry = Sentry; | |
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
// disable pageload transaction | ||
integrations: [Sentry.BrowserTracing({ tracingOrigins: ['http://example.com'], startTransactionOnPageLoad: false })], | ||
integrations: [Sentry.browserTracingIntegration({ instrumentPageLoad: false })], | ||
tracePropagationTargets: ['http://example.com'], | ||
tracesSampleRate: 1, | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
import { Integrations } from '@sentry/tracing'; | ||
|
||
window.Sentry = Sentry; | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [new Integrations.BrowserTracing({ tracingOrigins: ['http://example.com'] })], | ||
integrations: [Sentry.browserTracingIntegration()], | ||
tracePropagationTargets: ['http://example.com'], | ||
tracesSampleRate: 1, | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
import { Integrations } from '@sentry/tracing'; | ||
|
||
window.Sentry = Sentry; | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [new Integrations.BrowserTracing({ tracingOrigins: ['http://example.com'] })], | ||
integrations: [Sentry.browserTracingIntegration()], | ||
tracePropagationTargets: ['http://example.com'], | ||
tracesSampleRate: 1, | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ window.Sentry = Sentry; | |
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
// disable pageload transaction | ||
integrations: [Sentry.BrowserTracing({ tracingOrigins: ['http://example.com'], startTransactionOnPageLoad: false })], | ||
integrations: [Sentry.browserTracingIntegration({ instrumentPageLoad: false })], | ||
tracePropagationTargets: ['http://example.com'], | ||
tracesSampleRate: 1, | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,8 +24,8 @@ module.exports = function (environment) { | |
tracesSampleRate: 1, | ||
// Include fake dsn so that instrumentation is enabled when running from cli | ||
dsn: process.env.SENTRY_DSN || 'https://[email protected]/0', | ||
tracePropagationTargets: ['localhost', 'doesntexist.example'], | ||
browserTracingOptions: { | ||
tracingOrigins: ['localhost', 'doesntexist.example'], | ||
_experiments: { | ||
// This lead to some flaky tests, as that is sometimes logged | ||
enableLongTask: false, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This likely needs to be rewritten since we're removing
BrowserTracing
completely anyway but for now it's okay. Was just worried because we didn't mention that we removedtracePropaagationTargets
in theBrowserTracing
options but realized it's not gonna matter 😅