feat(feedback): Add getFeedback utility to get typed feedback instance
#11331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure the `feedbackIntegration` returns a properly typed response.
Bundle ReportChanges will decrease total bundle size by 2.87MB ⬇️
|
size-limit report 📦
|
ryan953
approved these changes
Mar 28, 2024
ryan953
reviewed
Mar 28, 2024
| @@ -279,5 +282,3 @@ export const _feedbackIntegration = (({ | |||
| }, | |||
| }; | |||
| }) satisfies IntegrationFn; | |||
|
|
|||
| export const feedbackIntegration = defineIntegration(_feedbackIntegration); | |||
There was a problem hiding this comment.
for reference, the reason we generally have this is because for most integrations, we do not want to expose to users what shape they have, as then we cannot refactor internals anymore - we only expose it if we have to (which we do for replay & feedback) :)
c298lee
approved these changes
Mar 28, 2024
|
related to #10941 |
3 tasks
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…nce (getsentry#11331) Also ensure the `feedbackIntegration` returns a properly typed response. This should make it easier to manually interact with feedbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure the
feedbackIntegrationreturns a properly typed response.This should make it easier to manually interact with feedbacks.