Skip to content

fix: DOMError and DOMException should be error level events #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

fix: DOMError and DOMException should be error level events #1871

merged 1 commit into from
Feb 6, 2019

Conversation

kamilogorek
Copy link
Contributor

Resolves #1864

@kamilogorek kamilogorek requested a review from HazAT February 6, 2019 11:13
@kamilogorek kamilogorek mentioned this pull request Feb 6, 2019
Closed
8 tasks
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Feb 6, 2019 •
edited
Loading

Messages
📖 ✅ TSLint passed
📖 @sentry/browser gzip'ed minified size: 21.9131 kB

Generated by 🚫 dangerJS

@kamilogorek kamilogorek force-pushed the correct-domexception-level branch from a1f9972 to 7a49a69 Compare February 6, 2019 11:47
HazAT added a commit that referenced this pull request Feb 6, 2019
@HazAT
feat: #1871
14ffee1
@kamilogorek kamilogorek merged commit 28b8164 into master Feb 6, 2019
@kamilogorek kamilogorek deleted the correct-domexception-level branch February 6, 2019 15:01
HazAT added a commit that referenced this pull request Feb 8, 2019
@HazAT
Use SyncPromise internally & Remove deprecated API & Trim Public API (#…
459fdd8 
…1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871
HazAT added a commit that referenced this pull request Feb 13, 2019
@HazAT
Use SyncPromise internally & Remove deprecated API & Trim Public API (#…
7f0ab14 
…1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871
HazAT added a commit that referenced this pull request Feb 15, 2019
@HazAT
Use SyncPromise internally & Remove deprecated API & Trim Public API (#…
e675ef2 
…1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871
HazAT added a commit that referenced this pull request Feb 15, 2019
@HazAT
Use SyncPromise internally & Remove deprecated API & Trim Public API (#…
b00476d 
…1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871
HazAT added a commit that referenced this pull request Feb 18, 2019
@HazAT
ref: Move public interfaces to types package (#1889)
e2415b6 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)

* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871

* ref: Move public interfaces to types package

Move addBreadcrumb from the client to the hub

* fix: Tests

* fix: Small type issues

* ref: Remove scope listeners

* fix: Add flush to interface

* ref: Remove interfaces from core
kamilogorek pushed a commit that referenced this pull request Feb 19, 2019
@HazAT @kamilogorek
Use SyncPromise internally & Remove deprecated API & Trim Public API (#…
776bfca 
…1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871
kamilogorek pushed a commit that referenced this pull request Feb 19, 2019
@HazAT @kamilogorek
ref: Move public interfaces to types package (#1889)
8863965 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)

* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871

* ref: Move public interfaces to types package

Move addBreadcrumb from the client to the hub

* fix: Tests

* fix: Small type issues

* ref: Remove scope listeners

* fix: Add flush to interface

* ref: Remove interfaces from core
HazAT added a commit that referenced this pull request Feb 21, 2019
@HazAT
Use SyncPromise internally & Remove deprecated API & Trim Public API (#…
0d0594a 
…1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871
HazAT added a commit that referenced this pull request Feb 21, 2019
@HazAT
ref: Move public interfaces to types package (#1889)
d074c1c 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)

* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871

* ref: Move public interfaces to types package

Move addBreadcrumb from the client to the hub

* fix: Tests

* fix: Small type issues

* ref: Remove scope listeners

* fix: Add flush to interface

* ref: Remove interfaces from core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilogorek @getsentry-bot @HazAT