Skip to content

[WIP] ref: Move public interfaces to types package #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 18, 2019
Merged

[WIP] ref: Move public interfaces to types package #1889

merged 8 commits into from
Feb 18, 2019

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Feb 13, 2019

No description provided.

@HazAT HazAT added this to the 5.0.0 milestone Feb 13, 2019
@HazAT HazAT self-assigned this Feb 13, 2019
@HazAT HazAT requested a review from kamilogorek as a code owner February 13, 2019 16:49
@HazAT
Copy link
Member Author

HazAT commented Feb 14, 2019

Why are the tests not running at all? 🤔

kamilogorek and others added 7 commits February 15, 2019 12:35
@kamilogorek @HazAT
fix: Events created from exception shouldnt have top-level message at…
8fcc426 
…tribute (#1831)
@HazAT
Use SyncPromise internally & Remove deprecated API & Trim Public API (#…
b00476d 
…1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871
@HazAT
ref: Move public interfaces to types package
9ecadd7 
Move addBreadcrumb from the client to the hub
@HazAT
fix: Tests
9524145
@HazAT
fix: Small type issues
d320611
@HazAT
ref: Remove scope listeners
d1725ed
@HazAT
fix: Add flush to interface
179dc53
@HazAT HazAT force-pushed the ref/unify-interfaces branch from 7b85826 to 179dc53 Compare February 15, 2019 11:45
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Feb 15, 2019 •
edited
Loading

Messages
📖 ✅ TSLint passed
📖 @sentry/browser gzip'ed minified size: 21.4326 kB

Generated by 🚫 dangerJS

@HazAT HazAT merged commit e2415b6 into major/5 Feb 18, 2019
@HazAT HazAT deleted the ref/unify-interfaces branch February 18, 2019 09:19
kamilogorek pushed a commit that referenced this pull request Feb 19, 2019
@HazAT @kamilogorek
ref: Move public interfaces to types package (#1889)
8863965 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)

* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871

* ref: Move public interfaces to types package

Move addBreadcrumb from the client to the hub

* fix: Tests

* fix: Small type issues

* ref: Remove scope listeners

* fix: Add flush to interface

* ref: Remove interfaces from core
HazAT added a commit that referenced this pull request Feb 21, 2019
@HazAT
ref: Move public interfaces to types package (#1889)
d074c1c 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)

* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)

* ref: Move PromiseBuffer and Error to utils package

* ref: Remove all async api

* ref: Remove invokeClientAsync function

* feat: Finish Node SDK

* feat: SyncPromise implementation

* fix: Browser SDK

* fix: beforeSend callback

* fix: Core tests

* fix: linting and tests

* fix: browser npm package + add error for manual tests

* meta: Remove deprecations

* fix: Typedocs and public exposed functions

* meta: Changelog

* Apply suggestions from code review

Co-Authored-By: HazAT <[email protected]>

* fix: CodeReview

* feat: #1871

* ref: Move public interfaces to types package

Move addBreadcrumb from the client to the hub

* fix: Tests

* fix: Small type issues

* ref: Remove scope listeners

* fix: Add flush to interface

* ref: Remove interfaces from core
kamilogorek pushed a commit that referenced this pull request Feb 26, 2019
@HazAT @kamilogorek
ref: Move public interfaces to @sentry/types package (#1889)
59c804c 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)
* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)
* ref: Move PromiseBuffer and Error to utils package
* ref: Remove all async api
* ref: Remove invokeClientAsync function
* feat: Finish Node SDK
* feat: SyncPromise implementation
* fix: Browser SDK
* fix: beforeSend callback
* fix: Core tests
* fix: linting and tests
* fix: browser npm package + add error for manual tests
* meta: Remove deprecations
* fix: Typedocs and public exposed functions
* meta: Changelog
* Apply suggestions from code review
* ref: Move public interfaces to types package
* fix: Tests
* fix: Small type issues
* ref: Remove scope listeners
* fix: Add flush to interface
* ref: Remove interfaces from core
HazAT added a commit that referenced this pull request Mar 19, 2019
@HazAT
ref: Move public interfaces to @sentry/types package (#1889)
633e943 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)
* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)
* ref: Move PromiseBuffer and Error to utils package
* ref: Remove all async api
* ref: Remove invokeClientAsync function
* feat: Finish Node SDK
* feat: SyncPromise implementation
* fix: Browser SDK
* fix: beforeSend callback
* fix: Core tests
* fix: linting and tests
* fix: browser npm package + add error for manual tests
* meta: Remove deprecations
* fix: Typedocs and public exposed functions
* meta: Changelog
* Apply suggestions from code review
* ref: Move public interfaces to types package
* fix: Tests
* fix: Small type issues
* ref: Remove scope listeners
* fix: Add flush to interface
* ref: Remove interfaces from core
HazAT added a commit that referenced this pull request Mar 20, 2019
@HazAT
ref: Move public interfaces to @sentry/types package (#1889)
9e862ab 
* fix: Events created from exception shouldnt have top-level message attribute (#1831)
* Use SyncPromise internally & Remove deprecated API & Trim Public API (#1858)
* ref: Move PromiseBuffer and Error to utils package
* ref: Remove all async api
* ref: Remove invokeClientAsync function
* feat: Finish Node SDK
* feat: SyncPromise implementation
* fix: Browser SDK
* fix: beforeSend callback
* fix: Core tests
* fix: linting and tests
* fix: browser npm package + add error for manual tests
* meta: Remove deprecations
* fix: Typedocs and public exposed functions
* meta: Changelog
* Apply suggestions from code review
* ref: Move public interfaces to types package
* fix: Tests
* fix: Small type issues
* ref: Remove scope listeners
* fix: Add flush to interface
* ref: Remove interfaces from core
@lforst lforst mentioned this pull request Jul 1, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HazAT @getsentry-bot @kamilogorek