-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Feature]: Adds Optional Opt-out of Reporting Vue propsData #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Adds Optional Opt-out of Reporting Vue propsData #1885
Conversation
- gives user the option to opt out of reporting props - switch is added to options at constructor
@ericnograles thanks! Yes, TravisCI cannot run SauceLabs tests from external contributors, but you don't have to worry about them. Docs are here – https://github.com/getsentry/sentry-docs/blob/master/src/collections/_documentation/platforms/javascript/vue.md Can we change the name of the option to Thanks! |
Also |
Good call @kamilogorek. I added proper docs to the new flag, let me know if the description is sufficient. Working on the other changes now, will be up shortly. Thanks! |
- attachProps key to suppress sending propsData
Ready for re-review @kamilogorek Please note the corresponding doc update: getsentry/sentry-docs#769 Thanks again! |
Awesome, thank you! :) |
Summary
attachProps
is added to options at constructorrefs #1879
Notes
No unit/integration tests seem to exist for
Integrations.Vue
-- if someone could point me to an example of how to get that together, I'd be happy to provide oneIt doesn't seem like y'all host your docs on GH, as I was looking to update that as well with this new option. If I just missed it somewhere in the repo, please lmk where it is and I'll update the Markdown file
If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (
yarn lint
) & (yarn test
).