Skip to content

[Feature]: Adds Optional Opt-out of Reporting Vue propsData #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericnograles
Copy link
Contributor

@ericnograles ericnograles commented Feb 12, 2019

Summary

  • Gives user the option to opt out of reporting props
    • attachProps is added to options at constructor

refs #1879

Notes

  • No unit/integration tests seem to exist for Integrations.Vue -- if someone could point me to an example of how to get that together, I'd be happy to provide one

  • It doesn't seem like y'all host your docs on GH, as I was looking to update that as well with this new option. If I just missed it somewhere in the repo, please lmk where it is and I'll update the Markdown file

  • If you've added code that should be tested, please add tests.

  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

- gives user the option to opt out of reporting props
- switch is added to options at constructor
@ericnograles
Copy link
Contributor Author

Just a head's up, looks like there's something broken in the Travis CI config:

image

@kamilogorek
Copy link
Contributor

@ericnograles thanks! Yes, TravisCI cannot run SauceLabs tests from external contributors, but you don't have to worry about them.

Docs are here – https://github.com/getsentry/sentry-docs/blob/master/src/collections/_documentation/platforms/javascript/vue.md

Can we change the name of the option to attachProps and reverse logical check?
We already have attachStacktrace configuration option in the SDK and it would align nicely.

Thanks!

@kamilogorek
Copy link
Contributor

Also inheritDocs doesnt work here, as this attribute is not inherited. If you could write proper doc line for it would be great :)

@ericnograles
Copy link
Contributor Author

ericnograles commented Feb 12, 2019

Good call @kamilogorek. I added proper docs to the new flag, let me know if the description is sufficient.

Working on the other changes now, will be up shortly.

Thanks!

ericnograles pushed a commit to ericnograles/sentry-docs that referenced this pull request Feb 12, 2019
- attachProps key to suppress sending propsData
@ericnograles
Copy link
Contributor Author

Ready for re-review @kamilogorek

Please note the corresponding doc update: getsentry/sentry-docs#769

Thanks again!

@kamilogorek kamilogorek merged commit eeab4c1 into getsentry:master Feb 13, 2019
kamilogorek pushed a commit to getsentry/sentry-docs that referenced this pull request Feb 13, 2019
@kamilogorek
Copy link
Contributor

Awesome, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants