Skip to content

[Feature]: Adds Optional Opt-out of Reporting Vue propsData #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2019
Merged

[Feature]: Adds Optional Opt-out of Reporting Vue propsData #1885

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01978bc
adds a hideProps key to options
Feb 12, 2019
ef731fb
Merge branch 'master' into feature/opt-out-propsdata-reporting
ericnograles Feb 12, 2019
ab90bc6
updates documentation
Feb 12, 2019
444a3d8
changes name from hideProps to attachProps and inverts logic
Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/browser/src/integrations/pluggable/vue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,22 @@ export class Vue implements Integration {
*/
private readonly Vue: any; // tslint:disable-line:variable-name

/**
* When set to false, Sentry will suppress reporting all props data
* from your Vue components for privacy concerns.
*/
private readonly attachProps: boolean;

/**
* @inheritDoc
*/
public constructor(options: { Vue?: any } = {}) {
public constructor(options: { Vue?: any; attachProps?: boolean } = {}) {
this.Vue =
options.Vue ||
(getGlobalObject() as {
Vue: any;
}).Vue;
this.attachProps = options.attachProps || true;
}

/** JSDoc */
Expand Down Expand Up @@ -69,7 +76,10 @@ export class Vue implements Integration {

if (isPlainObject(vm)) {
metadata.componentName = this.formatComponentName(vm);
metadata.propsData = vm.$options.propsData;

if (this.attachProps) {
metadata.propsData = vm.$options.propsData;
}
}

if (!isUndefined(info)) {
Expand Down