build: Build AWS Lambda Layer after building dist #4246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
approved these changes
Dec 7, 2021
| @@ -41,7 +41,7 @@ | |||
| "typescript": "3.7.5" | |||
| }, | |||
| "scripts": { | |||
| "build": "run-p build:cjs build:esm build:awslambda-layer", | |||
| "build": "run-p build:cjs build:esm && yarn build:awslambda-layer", | |||
There was a problem hiding this comment.
How does && interact with run-p?
a) yarn build:awslambda-layer runs after run-p has finished.
b) yarn build:awslambda-layer runs after build:esm has finished, potentially when build:cjs has not finished yet.
Didn't find the answer in the docs.
There was a problem hiding this comment.
Building the aws lambda layer will occur after run-p has executed
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn build:awslambda-layerrequires adistto exist to work. Previously we were running all the commands in parallel, so there was a chance that thedistdid not exist.