Skip to content

build: Build AWS Lambda Layer after building dist #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021
Merged

build: Build AWS Lambda Layer after building dist #4246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"typescript": "3.7.5"
},
"scripts": {
"build": "run-p build:cjs build:esm build:awslambda-layer",
"build": "run-p build:cjs build:esm && yarn build:awslambda-layer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does && interact with run-p?
a) yarn build:awslambda-layer runs after run-p has finished.
b) yarn build:awslambda-layer runs after build:esm has finished, potentially when build:cjs has not finished yet.

Didn't find the answer in the docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the aws lambda layer will occur after run-p has executed

"build:awslambda-layer": "node scripts/build-awslambda-layer.js",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build:cjs build:esm",
Expand Down