Skip to content

ref(browser): Extract private methods from Dedupe integration #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2021
Merged

ref(browser): Extract private methods from Dedupe integration #4294

merged 1 commit into from
Dec 15, 2021

Conversation

AbhiPrasad
Copy link
Member

Move out private methods into their own functions as they do not need
access to class properties. This helps save on bundle size.

@AbhiPrasad
ref(browser): Extract private methods from Dedupe integration
542c592 
Move out private methods into their own functions as they do not need
access to class properties. This helps save on bundle size.
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (f32cd36) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 21.39 KB 21.38 KB -0.02% 🔽
@sentry/browser - CDN Bundle (minified) 69.89 KB 69.77 KB -0.19% 🔽
@sentry/browser - Webpack 23.15 KB 23.08 KB -0.32% 🔽
@sentry/browser - Webpack - gzip = false 81.05 KB 80.72 KB -0.42% 🔽
@sentry/react - Webpack 23.19 KB 23.12 KB -0.32% 🔽
@sentry/nextjs Client - Webpack 47.77 KB 47.73 KB -0.09% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.69 KB 29.69 KB -0.01% 🔽

@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 15, 2021
@mitsuhiko mitsuhiko merged commit edf1be9 into master Dec 15, 2021
@mitsuhiko mitsuhiko deleted the abhi-dedupe-private branch December 15, 2021 08:46
mitsuhiko added a commit that referenced this pull request Dec 15, 2021
@mitsuhiko
Revert "ref(browser): Extract private methods from Dedupe integration (…
25cafc8 
…#4294)"

This reverts commit edf1be9.
@mitsuhiko mitsuhiko mentioned this pull request Dec 15, 2021
Merged
mitsuhiko added a commit that referenced this pull request Dec 15, 2021
@mitsuhiko
Revert "ref(browser): Extract private methods from Dedupe integration (…
a60d7a5 
…#4294)" (#4297)

This reverts commit edf1be9.
@mitsuhiko
Copy link
Contributor

@AbhiPrasad i accidentally merged this and had to back it out again.

@AbhiPrasad AbhiPrasad restored the abhi-dedupe-private branch December 15, 2021 13:55
@AbhiPrasad
Copy link
Member Author

Opened #4302 and made it WIP while I fix tests

onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
@AbhiPrasad @onurtemizkan
ref(browser): Extract private methods from Dedupe integration (#4294)
1d60039 
Move out private methods into their own functions as they do not need
access to class properties. This helps save on bundle size.
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
@mitsuhiko @onurtemizkan
Revert "ref(browser): Extract private methods from Dedupe integration (…
cd85a5c 
…#4294)" (#4297)

This reverts commit edf1be9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Tree shaking / Bundle Size
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @mitsuhiko