Skip to content

ref(browser): Extract private methods from Dedupe integration #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 15, 2021
Merged

ref(browser): Extract private methods from Dedupe integration #4302

merged 4 commits into from
Dec 15, 2021

Conversation

AbhiPrasad
Copy link
Member

Move out private methods into their own functions as they do not need
access to class properties. This helps save on bundle size.

@AbhiPrasad
ref(browser): Extract private methods from Dedupe integration
542c592 
Move out private methods into their own functions as they do not need
access to class properties. This helps save on bundle size.
@AbhiPrasad AbhiPrasad mentioned this pull request Dec 15, 2021
Merged
@mitsuhiko mitsuhiko added this to the Treeshaking / Bundle Size milestone Dec 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021 •
edited
Loading

size-limit report

Path Base Size (21ea870) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 21.19 KB 21.19 KB -0.02% 🔽
@sentry/browser - CDN Bundle (minified) 67.98 KB 67.85 KB -0.19% 🔽
@sentry/browser - Webpack 22.92 KB 22.83 KB -0.36% 🔽
@sentry/browser - Webpack - gzip = false 78.82 KB 78.49 KB -0.43% 🔽
@sentry/react - Webpack 22.95 KB 22.87 KB -0.36% 🔽
@sentry/nextjs Client - Webpack 47.41 KB 47.35 KB -0.13% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.4 KB 29.39 KB -0.04% 🔽

@AbhiPrasad AbhiPrasad marked this pull request as ready for review December 15, 2021 16:49
@AbhiPrasad AbhiPrasad requested a review from mitsuhiko December 15, 2021 17:09
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 15, 2021 17:54
@AbhiPrasad AbhiPrasad merged commit fc938c9 into master Dec 15, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-dedupe-private branch December 15, 2021 18:08
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
@AbhiPrasad @onurtemizkan
ref(browser): Extract private methods from Dedupe integration (#4302)
6610cea 
Move out private methods into their own functions as they do not need
access to class properties. This helps save on bundle size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Tree shaking / Bundle Size
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @mitsuhiko