-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update @sentry/ember dependencies #5494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@k-fish Could you please take a look at this PR? The version of |
b054b26
to
9a7a1c2
Compare
Thanks for opening a PR! Think you'll need to update |
9a7a1c2
to
4176b5f
Compare
Hey @AbhiPrasad, thanks for pointing that out. Including the amended |
4176b5f
to
a4b4536
Compare
@AbhiPrasad I had to also update |
4ed4d72
to
cb8ef7d
Compare
@AbhiPrasad I have to tag you one more time - I updated the default node version to be 12 mainly because v10 met its EOL on 30 Apr 2021 and it also failed the build for the new version of embroider. |
Some of them are stale and are declared with ~, which restricts any minor updates. Also update README.md to require ember v3.24+ instead of v4+ because 3.24 is already used for testing targets via `ember-try.js`.
cb8ef7d
to
34fde5d
Compare
@getsentry/open-source |
Hey @azhiv! We unfortunately can’t accept this patch if we are bumping the default Node version. We only do this during major bumps to make sure folks don’t unexpectedly break. See: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king |
Understood, I'll try to proceed with node v10. |
@AbhiPrasad Can you please guide me on how to test the build locally against node v10? With v12
After sorting this out, I'm going to run |
Don't have the bandwidth to take a detailed look for the next couple days - but look at #5094 to understand our build system.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Some of them are stale and are declared with ~, which restricts any minor
updates.
Also update README.md to require ember v3.24+ instead of v4+ because 3.24 is
already used for testing targets via
ember-try.js
.Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).