chore: remove unused Makefile #5999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, this is used here: sentry-javascript/package.json Line 26 in 052aa6b we can prob just remove this anyway and fix the typedoc later. |
|
Ah, true. I will also remove it from the |
mydea
force-pushed
the
fn/remove-makefile
branch
from
04a37f4 to
73e06d0
Compare
This is currently broken, see #3871
Make commands are currently not used. Once/if we bring typedoc back, we can also bring this back (one way or another).
mydea
force-pushed
the
fn/remove-makefile
branch
from
73e06d0 to
cd20203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile is very old (the docs-related commands will def. fail as that code does not exist anymore), and as far as I can tell the
prepare-releasecommand is also not used anywhere - but I could obviously be missing something there!Alternatively we could also only remove the docs-related commands and leave the
prepare-releaseone as it was.