Fix travis slow builds #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
suggested changes
Feb 27, 2018
.travis.yml
Outdated
| install: travis_retry travis_wait composer update --no-interaction --prefer-dist --prefer-stable $COMPOSER_OPTIONS | ||
| install: | ||
| - composer install --prefer-dist | ||
| - composer remove friendsofphp/php-cs-fixer --dev |
There was a problem hiding this comment.
I would move this composer remove into the before install step, with a --no-update flag to avoid any actual modification of the vendor folder, it should be faster
There was a problem hiding this comment.
composer remove will launch composer install after delete row from file. Please, see last build.
There was a problem hiding this comment.
If you use the --no-update flag it will not.
.travis.yml
Outdated
| @@ -17,7 +17,10 @@ before_install: | |||
| - composer self-update | |||
| - composer global require hirak/prestissimo | |||
|
|
|||
| install: travis_retry travis_wait composer update --no-interaction --prefer-dist --prefer-stable $COMPOSER_OPTIONS | |||
| install: | |||
| - composer install --prefer-dist | |||
There was a problem hiding this comment.
Is this composer install pre-step still required?
agentsib
commented
Feb 27, 2018
|
@Jean85 Do I still have to do something on the task? Or are you considering another way to solve the problem? Thanks |
Jean85
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For improve perfomance we need:
friendsofphp/php-cs-fixerbefore UnitTestscstaskSee #110