Skip to content

Fix travis slow builds #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2018
Merged

Fix travis slow builds #112

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43b76fa
Fix travis slow builds
agentsib Feb 27, 2018
eda2f51
Remove composer install
agentsib Feb 27, 2018
5fa9999
No update flag
agentsib Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ before_install:
- composer self-update
- composer global require hirak/prestissimo

install: travis_retry travis_wait composer update --no-interaction --prefer-dist --prefer-stable $COMPOSER_OPTIONS
install:
- composer install --prefer-dist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this composer install pre-step still required?

- composer remove friendsofphp/php-cs-fixer --dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this composer remove into the before install step, with a --no-update flag to avoid any actual modification of the vendor folder, it should be faster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer remove will launch composer install after delete row from file. Please, see last build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use the --no-update flag it will not.

- travis_retry travis_wait composer update --no-interaction --prefer-dist --prefer-stable $COMPOSER_OPTIONS

script:
- vendor/bin/phpunit -v
Expand All @@ -36,7 +39,9 @@ jobs:
- composer require --dev phpstan/phpstan symfony/expression-language --no-interaction --prefer-dist --prefer-stable
- vendor/bin/phpstan analyse src --level 7 -c phpstan.neon
env: PHPSTAN=true
- script: vendor/bin/php-cs-fixer fix --verbose --diff --dry-run
- script:
- composer require friendsofphp/php-cs-fixer ^2.5 --dev
- vendor/bin/php-cs-fixer fix --verbose --diff --dry-run
env: CS-FIXER=true
- stage: coverage
php: 7.1
Expand Down