Skip to content

Avoid class alias as a BC mechanism #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Jan 23, 2020

This fixes #307. Using class_alias as a BC detection mechanism may break BC for third party packages.

@Jean85 Jean85 added the Bug label Jan 23, 2020
@Jean85 Jean85 added this to the 3.4 milestone Jan 23, 2020
@Jean85 Jean85 self-assigned this Jan 23, 2020
@Jean85 Jean85 force-pushed the avoid-class-alias branch from 7cd655b to 16d1f16 Compare January 23, 2020 18:00
@Jean85 Jean85 force-pushed the avoid-class-alias branch from 10f859b to 5360494 Compare January 23, 2020 18:06
@Jean85 Jean85 mentioned this pull request Jan 23, 2020
@Jean85
Copy link
Contributor Author

Jean85 commented Jan 23, 2020

Closing in favor of #309

@Jean85 Jean85 closed this Jan 23, 2020
@Jean85 Jean85 deleted the avoid-class-alias branch February 28, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class aliasing RequestEvent causes incompatibilities with other bundles that detect Symfony versions by checking class existance
1 participant