Skip to content

Move the static analysis and CS jobs to a separate GitHub Actions workflow #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2020
Merged

Move the static analysis and CS jobs to a separate GitHub Actions workflow #403

merged 1 commit into from
Dec 25, 2020

Conversation

Yozhef
Copy link
Contributor

@Yozhef Yozhef commented Dec 22, 2020

No description provided.

@Yozhef Yozhef changed the title feat(Work Flows) separated static analysis. Work Flows separated static analysis. Dec 22, 2020
@Yozhef
Copy link
Contributor Author

Yozhef commented Dec 23, 2020

@Jean85 can you review this change?
And how do you look to add more test on Symfony versions? Сurrently missing on version Symfony 5.

@Jean85
Copy link
Contributor

Jean85 commented Dec 23, 2020

@Jean85 can you review this change?
And how do you look to add more test on Symfony versions? Сurrently missing on version Symfony 5.

Sure, please add a 5.x job

@Yozhef
Copy link
Contributor Author

Yozhef commented Dec 24, 2020

@Jean85 in this pr #404 - update check in more Symfony version.

ste93cry
ste93cry suggested changes Dec 25, 2020
View reviewed changes
@ste93cry ste93cry added this to the 4.0 milestone Dec 25, 2020
@ste93cry ste93cry changed the title Work Flows separated static analysis. Move the static analysis and CS jobs to a separate GitHub Actions workflow Dec 25, 2020
@Yozhef Yozhef force-pushed the separatedStaticAnalysis branch 3 times, most recently from c93c5ec to 0ee66fe Compare December 25, 2020 21:27
@Yozhef
Copy link
Contributor Author

Yozhef commented Dec 25, 2020

@ste93cry In php-cs has problem hi not support run in php 8.0 - https://github.com/Yozhef/PHP-CS-Fixer/blob/2.17/php-cs-fixer#L26
I'll create a fix for them but I'll leave 7.4 here for now

@Yozhef Yozhef force-pushed the separatedStaticAnalysis branch from 0ee66fe to 9d39a99 Compare December 25, 2020 21:37
@Yozhef
Copy link
Contributor Author

Yozhef commented Dec 25, 2020

PHP-CS-Fixer/PHP-CS-Fixer#5394

@Yozhef Yozhef requested a review from ste93cry December 25, 2020 21:46
@ste93cry
Copy link
Contributor

In php-cs has problem hi not support run in php 8.0

It it supported to run the tool on PHP 8 if a certain environment variable is set, what is not supported is running the tool on code written using PHP 8 features. Anyway, it's fine for us to run the tool on PHP 7.4 👍

@ste93cry ste93cry merged commit f7ef17c into getsentry:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Yozhef @Jean85 @ste93cry