Skip to content

Work Flows separated Symfony integrations. #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Work Flows separated Symfony integrations. #404

wants to merge 5 commits into from

Conversation

Yozhef
Copy link
Contributor

@Yozhef Yozhef commented Dec 23, 2020

No description provided.

@Yozhef Yozhef force-pushed the addMoreSymfonyVersion branch 3 times, most recently from e85309f to ae09939 Compare December 23, 2020 20:19
@Yozhef Yozhef force-pushed the addMoreSymfonyVersion branch from ae09939 to bef3c39 Compare December 23, 2020 20:25
@Yozhef Yozhef force-pushed the addMoreSymfonyVersion branch from 693c1db to 7bfc616 Compare December 24, 2020 07:08
@Yozhef Yozhef force-pushed the addMoreSymfonyVersion branch 2 times, most recently from 0ee83aa to b52f427 Compare December 24, 2020 07:34
@Yozhef Yozhef force-pushed the addMoreSymfonyVersion branch from b52f427 to 77e60ee Compare December 24, 2020 10:24
@Yozhef Yozhef force-pushed the addMoreSymfonyVersion branch from 1bbb159 to fbdb855 Compare December 24, 2020 10:54
@Yozhef Yozhef mentioned this pull request Dec 24, 2020
Merged
@ste93cry
Copy link
Contributor

I don't understand what you are trying to achieve here. I would expect only one "CI" workflow that tests all PHP versions for all supported Symfony versions for both lowest and highest dependencies 🤔

Jean85
Jean85 suggested changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I'm 👎 on this one: with this split approach you either obtain a lot more jobs to run, or you do not test enough combinations of language and Symfony versions.

@Yozhef
Copy link
Contributor Author

Yozhef commented Jan 13, 2021

thanks for the feedback - I will make changes in the existing one

@Yozhef Yozhef closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yozhef @ste93cry @Jean85