-
Notifications
You must be signed in to change notification settings - Fork 179
[BUGFIX] fixes the configuration tree #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Jean85 The failing tests are the same as in the master branch. |
Hi @michaelzangerle, thanks a lot for this contibution! Master branch is green, to what failures are you referring to? Also, I would prefer to not remove the deprecated option from the readme. Can you add a paragraph called "Deprecated options" that just summarizes with a YAML snippet the deprecated structure of option? Thanks! |
@Jean85 Whoops it redirected me to the current build instead of the master build that's why I thought it also failed on master. But still do you have any idea why it's failing? It's not even in this bundle ...
Yes I can add the deprecated options to the readme but is there any value to it? They should not be used anyway ... |
I've restarted the latest build on master and it's still green. You should issue a As for the deprecated options in the README, I would like to write about that to leave a notice about the deprecation itself, something like this:
Feel free to copy-paste that and fill in the options. |
@Jean85 Done and tests pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! All good now!
Fixes issues discovered and discussed in issue #41.