Skip to content

[BUGFIX] fixes the configuration tree #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2017

Conversation

michaelzangerle
Copy link
Contributor

Fixes issues discovered and discussed in issue #41.

@michaelzangerle
Copy link
Contributor Author

@Jean85 The failing tests are the same as in the master branch.

@Jean85
Copy link
Contributor

Jean85 commented Aug 4, 2017

Hi @michaelzangerle, thanks a lot for this contibution!

Master branch is green, to what failures are you referring to?

Also, I would prefer to not remove the deprecated option from the readme. Can you add a paragraph called "Deprecated options" that just summarizes with a YAML snippet the deprecated structure of option?

Thanks!

@michaelzangerle
Copy link
Contributor Author

@Jean85 Whoops it redirected me to the current build instead of the master build that's why I thought it also failed on master. But still do you have any idea why it's failing? It's not even in this bundle ...

PHP Fatal error:  Class 'Raven_Processor_SanitizeDataProcessor' not found in /home/travis/build/getsentry/sentry-symfony/vendor/sentry/sentry/lib/Raven/Client.php on line 286

Yes I can add the deprecated options to the readme but is there any value to it? They should not be used anyway ...

@Jean85
Copy link
Contributor

Jean85 commented Aug 4, 2017

I've restarted the latest build on master and it's still green. You should issue a composer update --prefer-lowest to try and reproduce the issue in your local environment.

As for the deprecated options in the README, I would like to write about that to leave a notice about the deprecation itself, something like this:

Deprecated options

In previous releases of this bundle, some of the previous options where set outside of the options level of the configuration file. Those still work but are deprecated, and they will be dropped in the 2.x release, so you are advised to abandon them; to provide forward compatibility, they can be used alongside the standard syntax, but values must match. This is a list of those option:

sentry:
    deprecated-option1: ~
    deprecated-option2: ~
    deprecated-option3: ~
    ...

Feel free to copy-paste that and fill in the options.

@michaelzangerle
Copy link
Contributor Author

@Jean85 Done and tests pass now.

Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! All good now!

@Jean85 Jean85 merged commit 9e40753 into getsentry:master Aug 5, 2017
@Jean85 Jean85 modified the milestone: Stable release 1.0 Aug 5, 2017
Jean85 added a commit that referenced this pull request Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants