Preparations for stable release #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e services configuration to non-deprecated values
…red before loading a console command
Jean85
changed the title
|
This is no longer WIP, requesting reviews! |
dcramer
approved these changes
Aug 29, 2017
| ->prototype('scalar')->end() | ||
| ->defaultValue(array('%kernel.root_dir%/..')) | ||
| ->end() | ||
| ->arrayNode('excluded_app_paths') |
There was a problem hiding this comment.
these (and the others) are still configured somewhere yeah?
There was a problem hiding this comment.
Yes. I've already released a gradual upgrade path in the 0.8.3 release, see the changelog here and the related PR, #68.
Basically those where the deprecated, old config values, that were copied under options, since they are all direct Sentry client options. In here I'm just dropping the deprecated ones, the new ones are already in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to accomplish a bunch of improvements and cleanup for the upcoming 1.0 release.
Currently it does:
src/Sentry/SentryBundle->src/)sentry.optionsif it's a\Raven_ClientoptionExceptionListener; also the Client is no longer an optional argumentSentryExtensionTestThis is till a WIP, I will update this list as I will go on.