Skip to content

ci : fix cuda releases #10532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

ci : fix cuda releases #10532

merged 1 commit into from
Nov 26, 2024

Conversation

slaren
Copy link
Member

@slaren slaren commented Nov 26, 2024

Fix CUDA releases being skipped. Also changes other windows builds to windows-latest.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 26, 2024
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will not cause the same issue as in the whisper.cpp builds: ggml-org/whisper.cpp#2572 (comment)

@slaren
Copy link
Member Author

slaren commented Nov 26, 2024

I had changed it to windows-2019 in #7861 when a github runner update broke the CUDA build (and it is still broken for old versions of the CUDA toolkit), but I believe the other windows builds should work with windows-latest. Not sure what happened in the whisper CI. I will revert the change if it fails.

@slaren slaren merged commit c9b00a7 into master Nov 26, 2024
46 checks passed
@slaren slaren deleted the sl/fix-cuda-releases branch November 26, 2024 21:12
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants