Skip to content

fix CUDA CI by using a windows-2019 image #7861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2024
Merged

fix CUDA CI by using a windows-2019 image #7861

merged 6 commits into from
Jun 11, 2024

Conversation

slaren
Copy link
Member

@slaren slaren commented Jun 10, 2024

No description provided.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Jun 10, 2024
@slaren
Copy link
Member Author

slaren commented Jun 10, 2024

Unfortunately cmake does not pass --allow-unsupported-compiler to nvcc during compiler identification when using MSVC. There is a fix merged already, but it requires cmake 3.29.4.

@slaren slaren changed the title try to fix CUDA ci with --allow-unsupported-compiler fix CUDA ci by using a windows-2019 image Jun 10, 2024
@slaren
Copy link
Member Author

slaren commented Jun 10, 2024

The other options that I tried didn't work, but using the windows-2019 runner image seems to work.

@slaren slaren linked an issue Jun 10, 2024 that may be closed by this pull request
No successful releases from CI in the last 2 days. #7828
Closed
@slaren slaren changed the title fix CUDA ci by using a windows-2019 image fix CUDA CI by using a windows-2019 image Jun 10, 2024
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 11, 2024
@ggerganov ggerganov merged commit c2ce6c4 into master Jun 11, 2024
39 of 63 checks passed
@ggerganov ggerganov deleted the sl/test-fix-cuda-ci branch June 11, 2024 05:59
@ggerganov ggerganov mentioned this pull request Jun 11, 2024
Merged
@slaren slaren mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No successful releases from CI in the last 2 days.
3 participants
@slaren @ggerganov @mofosyne