Skip to content

Run make to build the project #6457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

limitedAtonement
Copy link
Contributor

Although anyone running cmake probably knows to run make, we may as well add it for completeness's sake.

@phymbert phymbert self-requested a review April 4, 2024 18:45
phymbert

This comment was marked as duplicate.

@phymbert phymbert dismissed their stale review April 4, 2024 18:47

according to @cebtenzzre comment, forgive my previous comment

@NeoZhangJianyu
Copy link
Collaborator

@limitedAtonement
Thank your fix!

This issue was created by another PR: #6141

The removed code is :

# Or, build all binary
cmake --build . --config Release -v

If good if you provide both make and cmake here.

@limitedAtonement
Copy link
Contributor Author

If good if you provide both make and cmake here.

I wasn't sure how to provide both, so I gave it the old college try. How does that look?

@phymbert phymbert merged commit 9472bce into ggml-org:master Apr 7, 2024
@arthw
Copy link
Collaborator

arthw commented Apr 7, 2024

OK, I will check and update if needed.

Thank you!

@abhilash1910
Copy link
Collaborator

I think this PR needs another look, from usability point of view .

@limitedAtonement
Copy link
Contributor Author

limitedAtonement commented Apr 17, 2024

@abhilash1910 What are your concerns? I used the instructions to build (using make, not cmake --build), and the usability seemed okay to me.

tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
@arthw
Copy link
Collaborator

arthw commented Apr 19, 2024

I test and find the parameter "cmake --build .. xxxx" is wrong in common build env.
I fix it by PR: #6755

@limitedAtonement limitedAtonement deleted the make-sources branch April 19, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants