-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Run make to build the project #6457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
according to @cebtenzzre comment, forgive my previous comment
@limitedAtonement This issue was created by another PR: #6141 The removed code is :
If good if you provide both make and cmake here. |
414b7ce
to
88b35f7
Compare
I wasn't sure how to provide both, so I gave it the old college try. How does that look? |
OK, I will check and update if needed. Thank you! |
I think this PR needs another look, from usability point of view . |
@abhilash1910 What are your concerns? I used the instructions to build (using |
I test and find the parameter "cmake --build .. xxxx" is wrong in common build env. |
Although anyone running
cmake
probably knows to runmake
, we may as well add it for completeness's sake.