-
Notifications
You must be signed in to change notification settings - Fork 12.2k
fix wrong parameter in cmd in readme-sycl.md #6755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fix!
cmake --build .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icpx -DLLAMA_SYCL_F16=ON | ||
# Or without "--build", run "make" next | ||
# Option 1: Use FP16 for better performance in long-prompt inference | ||
#cmake .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icpx -DLLAMA_SYCL_F16=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should not start with #
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FP16 is not recommended. It has worse performance in most of case than fp32.
so, mark by #
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, excellent observation. That is not a good way to notate that, though. I think the #
should be removed and add to the comment above something like: . Not generally recommended
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, this cmd is copied from the example/sycl/build.sh at beginning.
But next editor don't know it and modify it again and again. :)
When running
Using the instructions this pull request creates works as expected. ( |
This method should work well too. In latest version, there are two cmake cmds:
|
The build cmd in readme-sycl.md is wrong.
"cmake --build .." is incorrect after verify.
Correct it.