Skip to content

fix wrong parameter in cmd in readme-sycl.md #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix wrong parameter in cmd in readme-sycl.md #6755

merged 1 commit into from
Apr 19, 2024

Conversation

arthw
Copy link
Collaborator

@arthw arthw commented Apr 19, 2024

The build cmd in readme-sycl.md is wrong.
"cmake --build .." is incorrect after verify.
Correct it.

@arthw arthw requested a review from airMeng April 19, 2024 00:43
@arthw arthw merged commit bca40e9 into master Apr 19, 2024
Copy link
Collaborator

@abhilash1910 abhilash1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!

@phymbert phymbert deleted the fix_build_cmd branch April 19, 2024 08:47
cmake --build .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icpx -DLLAMA_SYCL_F16=ON
# Or without "--build", run "make" next
# Option 1: Use FP16 for better performance in long-prompt inference
#cmake .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icpx -DLLAMA_SYCL_F16=ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should not start with #.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FP16 is not recommended. It has worse performance in most of case than fp32.
so, mark by #

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, excellent observation. That is not a good way to notate that, though. I think the # should be removed and add to the comment above something like: . Not generally recommended.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, this cmd is copied from the example/sycl/build.sh at beginning.
But next editor don't know it and modify it again and again. :)

@limitedAtonement
Copy link
Contributor

When running cmake --build .. -D..., I get

Unknown argument -DLLAMA_SCL=ON

Using the instructions this pull request creates works as expected. (cmake --build . not cmake --build .. is correct in the pull request.)

@NeoZhangJianyu
Copy link
Collaborator

When running cmake --build .. -D..., I get

Unknown argument -DLLAMA_SCL=ON

Using the instructions this pull request creates works as expected. (cmake --build . not cmake --build .. is correct in the pull request.)

This method should work well too.
But this cmd will set and build all tools in llama.cpp. it will take more time.

In latest version, there are two cmake cmds:

cmake .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icpx
cmake --build . --config Release -j -v
``
The second cmd allow user choose to build one or all tools.
It will save more time.

So, I think current two cmds are better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants